fix(ci): restore publishing for @contentful packages []#10709
Merged
Jared Jolton (jjolton-contentful) merged 1 commit intomasterfrom Mar 20, 2026
Merged
fix(ci): restore publishing for @contentful packages []#10709Jared Jolton (jjolton-contentful) merged 1 commit intomasterfrom
Jared Jolton (jjolton-contentful) merged 1 commit intomasterfrom
Conversation
Jared Jolton (jjolton-contentful)
requested a review
from a team
as a code owner
Copilot started reviewing on behalf of
Jared Jolton (jjolton-contentful)
March 18, 2026 17:43
View session
Jared Jolton (jjolton-contentful)
force-pushed
the
fix/dam-app-base-ci
branch
from
399a10f to
ac2a4aa
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Restores the monorepo’s CI package publishing flow so @contentful/* packages are published to Contentful’s GitHub Packages registry (instead of being redirected to npmjs by the repo-level .npmrc), and ensures publish failures are surfaced in CI.
Changes:
- Remove the repo
.npmrcduring the CI publish step so CI’s~/.npmrcregistry/auth settings take effect. - Make
lerna publish from-gitfailures fail CI (remove silent error suppression). - Add
publishConfig.registry(andaccess) to publishable packages as a defense-in-depth registry override.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.circleci/config.yml |
Deletes repo .npmrc during publish setup to avoid overriding CI’s GitHub Packages config. |
package.json |
Updates publish-packages script to stop masking publish failures. |
packages/dam-app-base/package.json |
Adds publishConfig to force publishing to GitHub Packages. |
packages/ecommerce-app-base/package.json |
Adds publishConfig to force publishing to GitHub Packages. |
packages/eslint-plugin-contentful-apps/package.json |
Adds publishConfig to force publishing to GitHub Packages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Jared Jolton (jjolton-contentful)
force-pushed
the
fix/dam-app-base-ci
branch
from
ac2a4aa to
5a32b87
Compare
CI publish to GitHub Packages was silently failing because the project .npmrc (with @contentful:registry=https://registry.npmjs.org) overrides the CI-configured ~/.npmrc scope, causing lerna publish to target the wrong registry without auth. - Restore removal of project .npmrc during publish step (was in 4d728ad, mistakenly removed in b8576a9) - Remove silent error suppression on lerna publish from-git so publish failures are visible in CI - Add publishConfig to all publishable packages as defense-in-depth Made-with: Cursor
Jared Jolton (jjolton-contentful)
force-pushed
the
fix/dam-app-base-ci
branch
from
5a32b87 to
117d333
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
CI publish to GitHub Packages was silently failing because the project .npmrc (with
@contentful:registry=https://registry.npmjs.org) overrides the CI-configured ~/.npmrc scope, causing lerna publish to target the wrong registry without auth.These packages are intended to be published to Contentful's internal GitHub Packages registry, where they are then mirrored to the public NPM registry.
Approach
Testing steps
Breaking Changes
No
Dependencies and/or References
Deployment