Skip to content

adding ClientOptions::withoutMessageLogging#295

Merged
Paul Grigoruta (pgrigoruta) merged 2 commits intocontentful:masterfrom
brettmc:feature/without-message-logging
Oct 19, 2020
Merged

adding ClientOptions::withoutMessageLogging#295
Paul Grigoruta (pgrigoruta) merged 2 commits intocontentful:masterfrom
brettmc:feature/without-message-logging

Conversation

@brettmc
Copy link
Copy Markdown
Contributor

As a follow-up patch to #294 this patch exposes the ability to disable the logging
of messages via ClientOptions. The default behaviour remains to continue to log messages.
Bumped the minimum required version of contentful/core to ^3.1 in anticipation that the next release will indeed be v3.1.
In passing, update the php-vcr version requirement to the latest version, as the branch it was trying to use no longer exists.

As a follow-up patch to contentful#294 this patch exposes the ability to disable the logging
of messages via ClientOptions. The default behaviour remains to continue to log messages.
Bumped the minimum required version of contentful/core to ^3.1 in anticipation that the next release will indeed be v3.1.
In passing, update the php-vcr version requirement to the latest version, as the branch it was trying to use no longer exists.
@brettmc
Copy link
Copy Markdown
Contributor Author

Hello, here is my follow-up patch for disabling message logging (see #294).
I anticipated that the next release you'd do of contentful-core.php would be v3.1, so I've set the composer dependency to match.

…hanges there is no need to increase it's version
@pgrigoruta Paul Grigoruta (pgrigoruta) merged commit 73e419f into contentful:master Oct 19, 2020
@pgrigoruta
Copy link
Copy Markdown
Contributor

Paul Grigoruta (pgrigoruta) commented Oct 19, 2020

Thank you for your contribution Brett McBride (@brettmc) !

@brettmc
Copy link
Copy Markdown
Contributor Author

Hi Paul Grigoruta (@pgrigoruta) - contentful/core lib definitely does have new changes that this patch relies on, namely contentful/contentful-core.php#43. The patch won't work without those changes (I think it will silently do nothing) which is why I bumped the dependency up.
As a minimum, this change would require a new released version of contentful/core (composer may pick up the correct version anyway, but bumping the dependency to make it explicit felt like the "right way", according to semantic versioning).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants