feat: use offsetHeight for canvasGeometry [SPA-2804]#1149
Merged
Maxim Cheremisin (maxcheremisin) merged 1 commit intov3-prereleasefrom Jun 3, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Maxim Cheremisin (maxcheremisin)
requested a review
from Thomas Kellermeier (Chaoste)
Thomas Kellermeier (Chaoste)
approved these changes
Jun 3, 2025
Thomas Kellermeier (Chaoste)
changed the title
Maxim Cheremisin (maxcheremisin)
merged commit 6807858
into
v3-prerelease
17 checks passed
Maxim Cheremisin (maxcheremisin)
deleted the
feat/use_offset_height_for_canvas_geometery
branch
Thomas Kellermeier (Chaoste)
pushed a commit
that referenced
this pull request
Jun 4, 2025
Thomas Kellermeier (Chaoste)
pushed a commit
that referenced
this pull request
Jul 4, 2025
Maxim Cheremisin (maxcheremisin)
added a commit
that referenced
this pull request
Jul 9, 2025
Maxim Cheremisin (maxcheremisin)
added a commit
that referenced
this pull request
Aug 4, 2025
Thomas Kellermeier (Chaoste)
added a commit
that referenced
this pull request
Aug 6, 2025
* feat: introduce SDK capability dndMigration [SPA-2745] (#1134) * feat: introduce SDK capability nativeDnd * feat: rename flag to dndMigration * chore: allow v3-prerelease branch for lerna publishing * feat!: remove dnd [SPA-2803] (#1138) * feat: introduce SDK capability dndMigration [SPA-2745] (#1134) * feat: introduce SDK capability nativeDnd * feat: rename flag to dndMigration * feat: remove all code related to DND or any other canvas interaction * feat: merge EditorBlock and useComponent * feat: remove remaining DND code and make components render * feat: remove to be deprecated messages * fix: className render props order * feat(visual-editor): Send CanvasGeometryUpdated Event [SPA-2804] (#1144) * feat: add geometry update message * feat: send canvasGeometry update at every possible DOM change * style: split functions, simplify code, drop manual sourceEvent * fix: to be safe fire trailing debounce message as well * style: rename manuallyFireCanvasGeometryUpdate to sendCanvasGeometryUpdate * fix: dont update manually but ensure observer stays active * style: split resize and mutations into two separate effects * fix: send message argument type * fix: use message argument type * feat: use offsetHeight for canvasGeometry [] (#1149) * feat: listen to the entire html for canvas geometry, as there might be style changes only [SPA-2804] (#1155) * feat: [] skip hidden nodes (#1193) * fix: remove old PreviewUnboundImage and unnnecessary special casing (#1171) * fix: remove falsly kept file from merge conflict * fix: render empty carousel and containers with min width and height * fix: correctly render editor attribets on CustomImage * test: check created CSS code for merged pattern default * fix: adjust test due to removed border-box rule on every node * chore: remove v3 downstream CI updates as it didnt work anyways * chore: [] send initial canvas geometry (#1219) * fix: render cfVisibility in editor mode for CSR apps * fix: mocks in tests * fix: increase handshake timeout * chore: remove special casing from lerna and CI config for v3 branch --------- Co-authored-by: Maxim Cheremisin <maxcheremisin2008@gmail.com>
Thomas Kellermeier (Chaoste)
added a commit
that referenced
this pull request
Aug 6, 2025
…SPA-2744] (#1216) * feat: introduce SDK capability dndMigration [SPA-2745] (#1134) * feat: introduce SDK capability nativeDnd * feat: rename flag to dndMigration * chore: allow v3-prerelease branch for lerna publishing * feat!: remove dnd [SPA-2803] (#1138) * feat: introduce SDK capability dndMigration [SPA-2745] (#1134) * feat: introduce SDK capability nativeDnd * feat: rename flag to dndMigration * feat: remove all code related to DND or any other canvas interaction * feat: merge EditorBlock and useComponent * feat: remove remaining DND code and make components render * feat: remove to be deprecated messages * fix: className render props order * feat(visual-editor): Send CanvasGeometryUpdated Event [SPA-2804] (#1144) * feat: add geometry update message * feat: send canvasGeometry update at every possible DOM change * style: split functions, simplify code, drop manual sourceEvent * fix: to be safe fire trailing debounce message as well * style: rename manuallyFireCanvasGeometryUpdate to sendCanvasGeometryUpdate * fix: dont update manually but ensure observer stays active * style: split resize and mutations into two separate effects * fix: send message argument type * fix: use message argument type * feat: use offsetHeight for canvasGeometry [] (#1149) * feat: listen to the entire html for canvas geometry [SPA-2804] (#1155) * feat: [] skip hidden nodes (#1193) * fix: remove old PreviewUnboundImage and unnnecessary special casing (#1171) * fix: remove falsly kept file from merge conflict * fix: render empty carousel and containers with min width and height * fix: correctly render editor attribets on CustomImage * test: check created CSS code for merged pattern default * fix: adjust test due to removed border-box rule on every node * chore: remove v3 downstream CI updates as it didnt work anyways * chore: [] send initial canvas geometry (#1219) * fix: render cfVisibility in editor mode for CSR apps * fix: mocks in tests * fix: increase handshake timeout * chore: remove special casing from lerna and CI config for v3 branch --------- Co-authored-by: Maxim Cheremisin <maxcheremisin2008@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Use
document.documentElement.offsetHeightinstead ofdocument.documentElement.scrollHeight.When the node is removed,
scrollHeightdoesn’t change, and iframe height stays the same, because in the web app the iframe is stretched to 100% of the container that has the height based off the last iframe size.