This repository was archived by the owner on Jun 9, 2021. It is now read-only.
Adding Bynder browse media UI Extension#75
Merged
Frederik Lölhöffel (floelhoeffel) merged 8 commits intomasterfrom Oct 24, 2018
Merged
Adding Bynder browse media UI Extension#75Frederik Lölhöffel (floelhoeffel) merged 8 commits intomasterfrom
Frederik Lölhöffel (floelhoeffel) merged 8 commits intomasterfrom
Conversation
Frederik Lölhöffel (floelhoeffel)
requested a review
from Alex Suevalov (suevalov)
Jakub (jelz)
suggested changes
Oct 24, 2018
samples/bynder/extension.html
Outdated
| @@ -0,0 +1,92 @@ | |||
| <!DOCTYPE html> | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Add <meta charset="utf-8">
samples/bynder/extension.html
Outdated
| } | ||
|
|
||
| .logo { | ||
| background-image: url(https://www.bynder.com/static/3.0/dist/img/svg/glyph-blue.svg); |
samples/bynder/extension.html
Outdated
|
|
||
|
|
||
| <body> | ||
| <div class="logo"> |
Contributor
There was a problem hiding this comment.
Just <div class="logo"></div>
samples/bynder/extension.html
Outdated
| <div class="logo"> | ||
|
|
||
| </div> | ||
| <div id="bynder-compactview" data-fullScreen="true" data-assetTypes="image,video" data-autoload="false" data-button="Load media from bynder.com" |
Contributor
There was a problem hiding this comment.
Break line after every attribute so it's easier to follow.
samples/bynder/extension.html
Outdated
| }) | ||
|
|
||
|
|
||
| document.getElementById('bynder-compactview').addEventListener('click', function (e) { |
Contributor
There was a problem hiding this comment.
you don't use e, skip it
Contributor
There was a problem hiding this comment.
This is not addressed
Contributor
Author
There was a problem hiding this comment.
done
samples/bynder/extension.html
Outdated
|
|
||
|
|
||
| document.getElementById('bynder-compactview').addEventListener('click', function (e) { | ||
| if (isOpen === false) { |
samples/bynder/extension.html
Outdated
| }) | ||
|
|
||
| function renderIds(ids) { | ||
| if (!ids || ids.length === 0) { |
Contributor
There was a problem hiding this comment.
More defensive: !Array.isArray(ids) || ids.length < 1
samples/bynder/extension.html
Outdated
| api.window.updateHeight() | ||
| return | ||
| } | ||
| assetsListsContainer.style.display = 'block' |
Contributor
There was a problem hiding this comment.
Do it after HTML of the list is fully generated (your innerHTML manipulation)
samples/bynder/extension.html
Outdated
| } | ||
| }) | ||
| </script> | ||
| </body> No newline at end of file |
Contributor
Author
|
PTAL |
Jakub (jelz)
suggested changes
Oct 24, 2018
samples/bynder/extension.html
Outdated
| isOpen = false | ||
| // The selected assets go in the event detail property | ||
| var selectedAssets = e.detail | ||
| var assetIds = [] |
Contributor
There was a problem hiding this comment.
This is not addressed
samples/bynder/extension.html
Outdated
| }) | ||
|
|
||
|
|
||
| document.getElementById('bynder-compactview').addEventListener('click', function (e) { |
Contributor
There was a problem hiding this comment.
This is not addressed
Jakub (jelz)
suggested changes
Oct 24, 2018
Jakub (jelz)
approved these changes
Oct 24, 2018
samples/bynder/README.md
Outdated
| For local development, start a webserver: | ||
|
|
||
| ```bash | ||
| ❯python -m SimpleHTTPServer |
Contributor
There was a problem hiding this comment.
maybe drop the > so it can be copy/pasted w/o confusion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.