Skip to content

fix!: do not return undefined headers (Node 16 update) #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Manuel Spagnolo (shikaan) merged 10 commits into from
Aug 23, 2021
Merged

fix!: do not return undefined headers (Node 16 update) #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
30a502a
fix!: do not return undefined headers, cleanup
shikaan Aug 19, 2021
f29ae04
test!: cover no context case + cleanup
shikaan Aug 20, 2021
585c050
chore(deps): bump path-parse from 1.0.6 to 1.0.7 (#32)
dependabot[bot] Aug 19, 2021
80ed76d
chore: update docs
shikaan Aug 20, 2021
f9d2705
chore!: remove unsupported exports
shikaan Aug 20, 2021
5d7e592
chore: null-check context headers
shikaan Aug 20, 2021
25a09b9
chore: prettier names
shikaan Aug 20, 2021
95d1730
chore: update nvmrc
shikaan Aug 20, 2021
fb0f218
chore: style
shikaan Aug 23, 2021
4ac3403
Merge branch 'master' into fix/no-undefined-headers
shikaan Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v12.18.3
v16
13 changes: 5 additions & 8 deletions docs/globals.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,15 +129,15 @@ <h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">Promise</
<h2>Requests Functions</h2>
<section class="tsd-panel tsd-member tsd-kind-function">
<a name="signrequest" class="tsd-anchor"></a>
<h3><span class="tsd-flag ts-flagConst">Const</span> sign<wbr>Request</h3>
<h3>sign<wbr>Request</h3>
<ul class="tsd-signatures tsd-kind-function">
<li class="tsd-signature tsd-kind-icon">sign<wbr>Request<span class="tsd-signature-symbol">(</span>rawSecret<span class="tsd-signature-symbol">: </span><span class="tsd-signature-type">Secret</span>, rawCanonicalRequest<span class="tsd-signature-symbol">: </span><span class="tsd-signature-type">CanonicalRequest</span>, rawTimestamp<span class="tsd-signature-symbol">?: </span><span class="tsd-signature-type">Timestamp</span>, rawContextHeaders<span class="tsd-signature-symbol">?: </span><span class="tsd-signature-type">ContextHeaders</span><span class="tsd-signature-symbol">)</span><span class="tsd-signature-symbol">: </span><span class="tsd-signature-type">SignedRequestHeaders</span></li>
<li class="tsd-signature tsd-kind-icon">sign<wbr>Request<span class="tsd-signature-symbol">(</span>rawSecret<span class="tsd-signature-symbol">: </span><span class="tsd-signature-type">Secret</span>, rawCanonicalRequest<span class="tsd-signature-symbol">: </span><span class="tsd-signature-type">CanonicalRequest</span>, rawTimestamp<span class="tsd-signature-symbol">?: </span><span class="tsd-signature-type">Timestamp</span><span class="tsd-signature-symbol">)</span><span class="tsd-signature-symbol">: </span><span class="tsd-signature-type">SignedRequestWithoutContextHeaders</span></li>
</ul>
<ul class="tsd-descriptions">
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/contentful/node-apps-toolkit/blob/master/src/requests/sign-request.ts#L79">requests/sign-request.ts:79</a></li>
<li>Defined in <a href="https://github.com/contentful/node-apps-toolkit/blob/master/src/requests/sign-request.ts#L71">requests/sign-request.ts:71</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand All @@ -155,13 +155,10 @@ <h5>rawSecret: <span class="tsd-signature-type">Secret</span></h5>
<h5>rawCanonicalRequest: <span class="tsd-signature-type">CanonicalRequest</span></h5>
</li>
<li>
<h5><span class="tsd-flag ts-flagDefault value">Default value</span> rawTimestamp: <span class="tsd-signature-type">Timestamp</span><span class="tsd-signature-symbol"> = Date.now()</span></h5>
</li>
<li>
<h5><span class="tsd-flag ts-flagDefault value">Default value</span> rawContextHeaders: <span class="tsd-signature-type">ContextHeaders</span><span class="tsd-signature-symbol"> = {} as ContextHeaders</span></h5>
<h5><span class="tsd-flag ts-flagOptional">Optional</span> rawTimestamp: <span class="tsd-signature-type">Timestamp</span></h5>
</li>
</ul>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">SignedRequestHeaders</span></h4>
<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">SignedRequestWithoutContextHeaders</span></h4>
</li>
</ul>
</section>
Expand Down
Loading