Skip to content

Conversation

@shikaan
Copy link
Contributor

@shikaan shikaan commented May 10, 2021

No description provided.

@shikaan shikaan requested a review from a team May 10, 2021 14:50
}

export type ContentEntityType = 'Entry' | 'Asset'
export type ContentEntityType = 'Entry' | 'Asset' | string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: somewhere we use constant strings to address the Entity type, sometimes we use just string. Once types in CMA are fixed this can go back to a list of constant strings

@shikaan shikaan merged commit 16b15e2 into canary May 11, 2021
@shikaan shikaan deleted the fix/export-types branch May 11, 2021 08:49
ghost pushed a commit that referenced this pull request May 11, 2021
# [4.0.0-alpha.2](v4.0.0-alpha.1...v4.0.0-alpha.2) (2021-05-11)

### Bug Fixes

* include typings in the release ([#699](#699)) ([16b15e2](16b15e2))
@ghost
Copy link

ghost commented May 11, 2021

🎉 This PR is included in version 4.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released on @canary label May 11, 2021
loweisz pushed a commit that referenced this pull request Jun 30, 2021
* fix: include typings in the release

* chore: tweak space api types to adhere to cma.js

* refactor: Item -> Items

* revert: old tags api

* feat: export UserAPI
loweisz pushed a commit that referenced this pull request Jun 30, 2021
# [4.0.0-alpha.2](v4.0.0-alpha.1...v4.0.0-alpha.2) (2021-05-11)

### Bug Fixes

* include typings in the release ([#699](#699)) ([16b15e2](16b15e2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants