refactor: ♻️ query function accepts queryObj #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishaileshmishra
suggested changes
Jan 8, 2024
Member
ishaileshmishra
left a comment
ishaileshmishra
left a comment
There was a problem hiding this comment.
Please remove the credentials exposed in the test files
Member
|
Please check why Source Composition Analysis Scan / security (pull_request) is Failing |
Contributor
Author
|
@ishaileshmishra The source compilation test is failing because of dependency issue with core library. I have already resolved it in the core package and sent for SRE. As soon as new version is released, we'll be good with this test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query function earlier had another query function to accept query Object.
Refactored it to base query function.