Skip to content

API Error response from SDK #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uttamukkoji merged 1 commit into from
Sep 25, 2020
Merged

API Error response from SDK #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed dist/.DS_Store
View file
Open in desktop
Binary file not shown.
9 changes: 5 additions & 4 deletions dist/nativescript/contentstack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,7 +1063,7 @@ var Stack = function () {
* @example
* Stack.sync({'init': true, 'start_date': '2018-10-22'}) //For initializing sync with entries published after a specific date
* @example
* Stack.sync({'init': true, 'content_type_id': 'session'}) //For initializing sync with entries of a specific content type
* Stack.sync({'init': true, 'content_type_uid': 'session'}) //For initializing sync with entries of a specific content type
* @example
* Stack.sync({'init': true, 'type': 'entry_published'}) //Use the type parameter to get a specific type of content.Supports 'asset_published', 'entry_published', 'asset_unpublished', 'entry_unpublished', 'asset_deleted', 'entry_deleted', 'content_type_deleted'.
* @example
Expand Down Expand Up @@ -1200,14 +1200,15 @@ function Request(options, fetchOptions) {
}, fetchOptions);

(0, _http2.default)(url + '?' + queryParams, option).then(function (response) {
var data = response.json();
if (response.ok && response.status === 200) {
var data = response.json();
resolve(data);
} else {
reject(response.statusText);
return data;
}
}).then(function (json) {
reject(json);
}).catch(function (error) {
console.log("Error: ", error);
reject(error);
});
});
Expand Down
9 changes: 5 additions & 4 deletions dist/node/contentstack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,7 +1159,7 @@ var Stack = function () {
* @example
* Stack.sync({'init': true, 'start_date': '2018-10-22'}) //For initializing sync with entries published after a specific date
* @example
* Stack.sync({'init': true, 'content_type_id': 'session'}) //For initializing sync with entries of a specific content type
* Stack.sync({'init': true, 'content_type_uid': 'session'}) //For initializing sync with entries of a specific content type
* @example
* Stack.sync({'init': true, 'type': 'entry_published'}) //Use the type parameter to get a specific type of content.Supports 'asset_published', 'entry_published', 'asset_unpublished', 'entry_unpublished', 'asset_deleted', 'entry_deleted', 'content_type_deleted'.
* @example
Expand Down Expand Up @@ -1699,14 +1699,15 @@ function Request(options, fetchOptions) {
}, fetchOptions);

(0, _http2.default)(url + '?' + queryParams, option).then(function (response) {
var data = response.json();
if (response.ok && response.status === 200) {
var data = response.json();
resolve(data);
} else {
reject(response.statusText);
return data;
}
}).then(function (json) {
reject(json);
}).catch(function (error) {
console.log("Error: ", error);
reject(error);
});
});
Expand Down
9 changes: 5 additions & 4 deletions dist/react-native/contentstack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,7 +1063,7 @@ var Stack = function () {
* @example
* Stack.sync({'init': true, 'start_date': '2018-10-22'}) //For initializing sync with entries published after a specific date
* @example
* Stack.sync({'init': true, 'content_type_id': 'session'}) //For initializing sync with entries of a specific content type
* Stack.sync({'init': true, 'content_type_uid': 'session'}) //For initializing sync with entries of a specific content type
* @example
* Stack.sync({'init': true, 'type': 'entry_published'}) //Use the type parameter to get a specific type of content.Supports 'asset_published', 'entry_published', 'asset_unpublished', 'entry_unpublished', 'asset_deleted', 'entry_deleted', 'content_type_deleted'.
* @example
Expand Down Expand Up @@ -1200,14 +1200,15 @@ function Request(options, fetchOptions) {
}, fetchOptions);

(0, _http2.default)(url + '?' + queryParams, option).then(function (response) {
var data = response.json();
if (response.ok && response.status === 200) {
var data = response.json();
resolve(data);
} else {
reject(response.statusText);
return data;
}
}).then(function (json) {
reject(json);
}).catch(function (error) {
console.log("Error: ", error);
reject(error);
});
});
Expand Down
2 changes: 1 addition & 1 deletion dist/web/contentstack.js
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 5 additions & 4 deletions src/core/lib/request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,16 @@ export default function Request(options, fetchOptions) {
fetchOptions);

fetch(url + '?' + queryParams, option)
.then(function(response) {
.then(function(response) {
let data = response.json();
if (response.ok && response.status === 200) {
let data = response.json();
resolve(data);
} else {
reject(response.statusText);
return data;
}
}).then((json) => {
reject(json)
}).catch(function(error) {
console.log("Error: ", error);
reject(error);
});
});
Expand Down