Create resolver api#45
Merged
asmit-patil merged 4 commits intodevelopfrom Aug 14, 2020
Merged
Conversation
jbertel2
commented
Aug 12, 2020
Contributor
Author
|
I still notice one case that doesn't work, probably related to schema generation. When i query any union field for which the schema is generated by this branch, i get a graphql runtime error: e.g. results in |
Contributor
Author
|
|
jbertel2
commented
Aug 12, 2020
| unionType = unionType.concat('_Union = ', unions.join(' | ')); | ||
| types.push(unionType); | ||
|
|
||
| references.push({ |
Contributor
Author
There was a problem hiding this comment.
i believe just pushing an object with just a parent and a uid is not sufficient to resolve queries afterwards, as demonstrated by the runtime error that is looking for an internal field with a type
Contributor
Author
There was a problem hiding this comment.
while debugging, i noticed the related_to field being resolved by the default resolver and not the custom resolver we register...
Contributor
Author
There was a problem hiding this comment.
it looks like not all reference fields get our custom resolvers registered, but some fallback to the default resolver, with the runtime error as consequence. Not sure why yet...
jbertel2
commented
Aug 13, 2020
| }); | ||
| }); | ||
| groups.forEach(function (group) { | ||
| resolvers[group.parent] = (0, _defineProperty3.default)({}, group.field.uid, { |
Contributor
Author
There was a problem hiding this comment.
I believe this is the root cause of the remaining problem. References and groups can have the same parent, or multiple references/groups can have the same parent. In these cases, we are overwriting the previous resolver...
Contributor
Author
There was a problem hiding this comment.
See a7354b4 for a potential fix. This worked in my case...
Contributor
There was a problem hiding this comment.
Thanks @jbertel2 for notifying this issue and fixing it. We appreciate your contribution here.
asmit-patil
approved these changes
Aug 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to point out a potential issue, hence creating a PR to discuss this