Skip to content

Conversation

@Chhavi-Mandowara
Copy link
Contributor

fix: allow --type flag to create new project without prompting to select provider
fix: error handling for creating new GitHub projects
fix: support validating git remote url for SSH format
chore: update version in package.json file

Chhavi-Mandowara and others added 2 commits April 30, 2025 17:51
fix: allow --type flag to create new project without prompting to select  provider
@Chhavi-Mandowara Chhavi-Mandowara requested a review from a team May 6, 2025 09:13
@Chhavi-Mandowara Chhavi-Mandowara requested a review from a team as a code owner May 6, 2025 09:13
@tejas-contentstack tejas-contentstack requested a review from Copilot May 6, 2025 09:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances error handling for creating new GitHub projects, adds support for validating git remote URLs in SSH format, and updates the version in package.json.

  • Refactors provider type selection by replacing a direct call to selectProjectType with a new helper, setProviderType.
  • Improves error handling and validates input flags to streamline project creation.
  • Updates test cases to account for the new --type flag behavior.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/commands/launch/index.ts Refactor to use setProviderType for provider handling and adjust inline command examples.
src/commands/launch/index.test.ts Adds a new test to verify that passing the provider flag bypasses prompting.
Files not reviewed (1)
  • .talismanrc: Language not supported
Comments suppressed due to low confidence (1)

src/commands/launch/index.test.ts:118

  • The test expects 'prepareApiClientsMock' and 'preCheckRunMock' to be called, but their initialization is not shown in the diff. Ensure these spies are properly set up so the test accurately verifies the behavior.
expect(prepareApiClientsMock).toHaveBeenCalled();

Copy link
Contributor

@dhruvparekh12 dhruvparekh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Chhavi-Mandowara Chhavi-Mandowara merged commit 4a5c1ba into staging May 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants