-
Notifications
You must be signed in to change notification settings - Fork 0
Fix issue regarding skipping env variables, suppressing non-dev error messages, parsing URL-formatted env values and handling empty server command inputs. #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Exclude .git folder when generating the zip file for deploying File Upload projects and Upgrade cli-utilites package version
Add Nuxt and Remix framework preset options
CL-2062 | +Harshi | Fix skip environment variables option with --vari…
fix: suppress error message in non-development environments
Add AGENTS.md file
fix: environment variable parsing for URL formatted values
fix: allow --variable-type flag to support multiple selections
fix: handle empty server command input properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements multiple fixes to improve the launch command functionality, including environment variable handling, Apollo Client warning suppression, and server command input validation. The changes upgrade Apollo Client to version 3.14.0 and add support for multiple variable-type flags, URL-formatted environment values, and proper handling of empty server command inputs.
Key Changes:
- Upgraded Apollo Client from 3.11.8 to 3.14.0 with console patching to suppress Apollo warnings in production
- Enhanced environment variable parsing to support URL-formatted values (e.g.,
https://api.example.com) - Modified
--variable-typeflag to accept multiple values and properly convert string to array format - Improved server command handling to conditionally include the field only when non-empty
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/util/apollo-client.ts | Added console patching to suppress Apollo-specific errors/warnings in non-development environments and exported isNotDevelopment flag |
| test/unit/util/apollo-client.test.ts | Added Mocha/Chai tests for console suppression behavior in development vs non-development environments |
| src/util/logs-polling-utilities.ts | Added withDeprecationsDisabled helper method to wrap Apollo Client queries and suppress deprecation warnings |
| src/adapters/base-class.ts | Added parseEnvVariablesString method to parse environment variables with colon-containing values and convert variableType string to array |
| src/adapters/base-class.test.ts | Added comprehensive tests for string-to-array conversion, multiple variable type selection, and URL parsing |
| src/commands/launch/index.ts | Updated variable-type flag to support multiple values with multiple: true option |
| src/adapters/github.ts | Modified server command handling to only include field when non-empty and updated variableType assignment |
| src/adapters/github.test.ts | Added comprehensive tests for server command prompt behavior and deployment flow |
| src/adapters/file-upload.ts | Modified server command handling to only include field when non-empty and updated variableType assignment |
| src/adapters/file-upload.test.ts | Added comprehensive tests for server command prompt behavior and file upload flow |
| package.json | Upgraded @apollo/client dependency from ^3.11.8 to ^3.14.0 |
| package-lock.json | Updated lock file with Apollo Client 3.14.0 dependencies |
| AGENTS.md | Added new testing guidelines document for AI agents |
| .github/CODEOWNERS | Updated code ownership rules to be more granular |
| .github/workflows/secrets-scan.yml | Removed secrets scanning workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix: skip environment variables option with --variable-type flag
fix: suppress error message in non-development environments
fix: environment variable parsing for URL formatted values
fix: allow --variable-type flag to accept multiple values
fix: handle empty server command input properly