[Feat/VB-499] Added resolved variants' permission communication and field disablement#500
Closed
csAyushDubey wants to merge 6 commits intodevelop_v4from
Closed
[Feat/VB-499] Added resolved variants' permission communication and field disablement#500csAyushDubey wants to merge 6 commits intodevelop_v4from
csAyushDubey wants to merge 6 commits intodevelop_v4from
Conversation
Contributor
hiteshshetty-dev
left a comment
hiteshshetty-dev
left a comment
There was a problem hiding this comment.
Can we please add test cases to check the order logic and other function how those interact with resolvedVariantPermissions
Comment on lines
+45
to
+50
| for (let i = variantOrder.length-1; i >= 0; i--) { | ||
| if (dataCslp.includes(variantOrder[i])) { | ||
| indexOfDataCslp = i; | ||
| break; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I would have resolved the variant details for CSLP and would have used indexOf.
Comment on lines
+20
to
+23
| return { | ||
| update: true, | ||
| }; | ||
| } |
Contributor
There was a problem hiding this comment.
If post message fails, we should consider this as older case where editing was not allowed.
I think it should be false, let me know if i am missing something.
Contributor
Author
There was a problem hiding this comment.
Yes, I've added a logic to handle that in the latest commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.