VB-277 :fix(VB-277/truncate-handlling):function added to remove and store styles#504
Merged
csAdityaPachauri merged 5 commits into1st-oct-2025from Sep 24, 2025
Merged
Conversation
csAdityaPachauri
changed the title
faraazb
suggested changes
Sep 16, 2025
Comment on lines
+60
to
+62
| originalElement.style.visibility = "hidden"; | ||
| originalElement.style.transition = "none"; | ||
| originalElement.style.animation = "none"; |
Contributor
There was a problem hiding this comment.
Please make a utility for hiding and showing the original element.
Comment on lines
+39
to
+41
| if (computedStyles.display && computedStyles.display.includes("box")) { | ||
| styles.display = computedStyles.display; | ||
| } |
Contributor
There was a problem hiding this comment.
I think we should avoid this. This will turn inline span into block elements.
faraazb
suggested changes
Sep 18, 2025
| } | ||
| >(); | ||
|
|
||
| export function clearVisibelityStyles(element: HTMLElement) { |
Contributor
There was a problem hiding this comment.
Suggested change
| export function clearVisibelityStyles(element: HTMLElement) { | |
| export function clearVisibilityStyles(element: HTMLElement) { |
Contributor
There was a problem hiding this comment.
Please add a description for this function
Contributor
Author
There was a problem hiding this comment.
@faraazb, can you please check once again?
done with the requested changes
| @@ -0,0 +1,34 @@ | |||
| const originalStyles = new WeakMap< | |||
Contributor
There was a problem hiding this comment.
Suggested change
| const originalStyles = new WeakMap< | |
| const elementStyles = new WeakMap< |
| element.style.animation = "none"; | ||
| } | ||
|
|
||
| export function restoreVisibelityStyles(element: HTMLElement) { |
Contributor
There was a problem hiding this comment.
Suggested change
| export function restoreVisibelityStyles(element: HTMLElement) { | |
| export function restoreVisibilityStyles(element: HTMLElement) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(visual-builder): implement style preservation for truncate handling
Add functions to store and restore element styles during truncation
Ensure visual state consistency when elements are truncated
Update overlay and focus state management for truncated elements