Skip to content

feat(visual-editor): request edit access workflow tooltips and canvas integration#572

Merged
hiteshshetty-dev merged 4 commits intodevelop_v4from
VB-1330
Mar 27, 2026
Merged

feat(visual-editor): request edit access workflow tooltips and canvas integration#572
hiteshshetty-dev merged 4 commits intodevelop_v4from
VB-1330

Conversation

@hiteshshetty-dev
Copy link
Copy Markdown
Contributor

@hiteshshetty-dev hiteshshetty-dev commented Mar 27, 2026

Summary

adds workflow stage details (including requestEditAccess), field-label UX for request/pending states, wider tooltip for workflow copy, OPEN_REQUEST_EDIT_ACCESS postMessage, and supporting styles.

This PR also adds tests

  • getWorkflowStageDetails.test.ts: postMessage payload, success path, permissive fallback when send returns undefined or throws
  • fieldLabelWrapper.workflowRequest.test.tsx: renders request/pending copy, workflow tooltip class (with corrected visualBuilder.style mock path), and OPEN_REQUEST_EDIT_ACCESS on click

Verification

  • npx vitest run src/visualBuilder/utils/__test__/getWorkflowStageDetails.test.ts src/visualBuilder/components/__test__/fieldlabelwrapper/fieldLabelWrapper.workflowRequest.test.tsx
  • npx vitest run src/visualBuilder/utils/__test__/isFieldDisabled.test.ts (existing workflow cases)

Notes

  • Tooltip max-width for workflow uses modifier class ordered after base .visual-builder__custom-tooltip so 325px wins over 200px in the stylesheet.

Made with Cursor

…verage

- Unit-test getWorkflowStageDetails postMessage payload and fallbacks
- Integration-style tests for request/pending copy, tooltip classes, and OPEN_REQUEST_EDIT_ACCESS
- Extend fieldLabelWrapper mock styles for workflow tooltip variants
- Fix visualBuilder.style mock path (../../../) so class assertions match mocked labels

Made-with: Cursor
@hiteshshetty-dev hiteshshetty-dev requested review from a team as code owners March 27, 2026 11:43
@github-actions
Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

@github-actions
Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 72.04% 8233 / 11428
🔵 Statements 72.04% 8233 / 11428
🔵 Functions 74.82% 327 / 437
🔵 Branches 85.82% 1253 / 1460
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/visualBuilder.style.ts 100% 100% 100% 100%
src/visualBuilder/components/fieldLabelWrapper.tsx 77.11% 77.1% 68.75% 77.11% 48-50, 58-60, 107-111, 116, 122, 135-137, 142-157, 174-178, 254-267, 270-274, 308-312, 316-345, 396-397, 401-406, 410, 475-477, 483-501
src/visualBuilder/utils/getWorkflowStageDetails.ts 100% 100% 100% 100%
src/visualBuilder/utils/isFieldDisabled.ts 97.66% 95.52% 100% 97.66% 106-107, 160-161
Generated in workflow #771 for commit 01dc87b by the Vitest Coverage Report Action

@hiteshshetty-dev hiteshshetty-dev changed the title feat(visual-builder): request edit access workflow tooltips and canvas integration feat(visual-editor): request edit access workflow tooltips and canvas integration Mar 27, 2026
Copy link
Copy Markdown

@kirtesh-cstk kirtesh-cstk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just get it manually tested from QA with possible scenarios like different entry permissions, request created, pending and done status UI/UX, etc

@hiteshshetty-dev hiteshshetty-dev merged commit a7aa3ff into develop_v4 Mar 27, 2026
9 checks passed
@hiteshshetty-dev hiteshshetty-dev deleted the VB-1330 branch March 27, 2026 12:12
@hiteshshetty-dev hiteshshetty-dev restored the VB-1330 branch March 27, 2026 12:27
@karancs06 karancs06 mentioned this pull request Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants