feat: enhance Docker setup and app configuration handling#1069
Merged
Conversation
shobhit-cstk
commented
May 13, 2026
shobhit-cstk
commented
- Added mounting of app.json in docker-compose.yml for better configuration access.
- Updated setup-docker.sh to check for app.json existence and provide clearer prompts for MySQL host input.
- Introduced a utility function to resolve the app.json path dynamically, improving flexibility in locating the configuration file.
- Refactored auth.service.ts and user.service.ts to utilize the new app configuration path utility.
- Updated tests to reflect changes in user service behavior regarding app organization checks.
- Added mounting of app.json in docker-compose.yml for better configuration access. - Updated setup-docker.sh to check for app.json existence and provide clearer prompts for MySQL host input. - Introduced a utility function to resolve the app.json path dynamically, improving flexibility in locating the configuration file. - Refactored auth.service.ts and user.service.ts to utilize the new app configuration path utility. - Updated tests to reflect changes in user service behavior regarding app organization checks.
vikrantraut-cstk
approved these changes
May 13, 2026
shradha-nahar
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.