test: add a claudeHookPayload factory for Claude hook tests

Valid hook events now come from a fishery factory (matching the existing
codexStopHookPayload one) instead of seven hand-rolled literals. Malformed
payload tests keep inline literals since they intentionally violate the type.

Author: blimmer

packages/cli/src/commands/hookClaude.test.ts

@@ -4,7 +4,7 @@ import { describe, expect, it } from 'bun:test';
 import { CommanderError } from 'commander';
 import { type RunAnnotationArgs, runAnnotation } from '#src/annotation/runAnnotation.ts';
 import { claudeHookResponse } from '#src/formatters/plan/claudeHookResponse.ts';
-import { annotationArgs } from '#src/testFactories.ts';
+import { annotationArgs, claudeHookPayload } from '#src/testFactories.ts';
 import { createAnnotationDependencies, createStubContext, readErrorLogs } from '#src/testHelpers/index.ts';
 import { type HookClaudeDependencies, runHookClaude } from './hookClaude.ts';
 
@@ -13,50 +13,30 @@ describe('hookClaude handler', () => {
     const { context, io } = createStubContext();
     const submission = annotationSubmission.build({ status: 'approved', threads: [] });
     const deps = createHookDependencies({ submission });
-    const toolInput = { plan: '# Plan\n\nStep 1.\n', planFilePath: '/home/user/.claude/plans/sample.md' };
-    io.stdin.write(
-      JSON.stringify({
-        session_id: 'sess_123',
-        transcript_path: '/tmp/transcript.json',
-        cwd: '/work',
-        permission_mode: 'plan',
-        hook_event_name: 'PermissionRequest',
-        tool_name: 'ExitPlanMode',
-        tool_input: toolInput,
-      }),
-    );
+    const payload = claudeHookPayload.build();
+    io.stdin.write(JSON.stringify(payload));
     io.stdin.end();
 
     await runHookClaude(context, deps);
 
-    expect(io.stdout.text()).toBe(`${JSON.stringify(claudeHookResponse(submission, toolInput))}\n`);
+    expect(io.stdout.text()).toBe(`${JSON.stringify(claudeHookResponse(submission, payload.tool_input))}\n`);
     const parsed = JSON.parse(io.stdout.text().trim()) as ReturnType<typeof claudeHookResponse>;
     if (parsed.hookSpecificOutput.decision.behavior !== 'allow') throw new Error('expected allow');
-    expect(parsed.hookSpecificOutput.decision.updatedInput).toEqual(toolInput);
-    expect(deps.calls).toEqual([annotationArgs.build({ content: '# Plan\n\nStep 1.\n', entrypoint: 'hook_claude' })]);
+    expect(parsed.hookSpecificOutput.decision.updatedInput).toEqual(payload.tool_input);
+    expect(deps.calls).toEqual([annotationArgs.build({ content: payload.tool_input.plan, entrypoint: 'hook_claude' })]);
   });
 
   it('emits a deny envelope with the markdown feedback when changes are requested', async () => {
     const { context, io } = createStubContext();
     const submission = annotationSubmission.build();
     const deps = createHookDependencies({ submission });
-    const planContent = '# Plan\n\nStep 1.\n';
-    io.stdin.write(
-      JSON.stringify({
-        session_id: 'sess_123',
-        transcript_path: '/tmp/transcript.json',
-        cwd: '/work',
-        permission_mode: 'plan',
-        hook_event_name: 'PermissionRequest',
-        tool_name: 'ExitPlanMode',
-        tool_input: { plan: planContent },
-      }),
-    );
+    const payload = claudeHookPayload.build();
+    io.stdin.write(JSON.stringify(payload));
     io.stdin.end();
 
     await runHookClaude(context, deps);
 
-    const expected = claudeHookResponse(submission, { plan: planContent });
+    const expected = claudeHookResponse(submission, payload.tool_input);
     expect(io.stdout.text()).toBe(`${JSON.stringify(expected)}\n`);
     const parsed = JSON.parse(io.stdout.text().trim()) as typeof expected;
     expect(parsed.hookSpecificOutput.decision.behavior).toBe('deny');
@@ -70,17 +50,7 @@ describe('hookClaude handler', () => {
     const deps: HookClaudeDependencies = {
       runReview: (reviewCtx, args) => runAnnotation(reviewCtx, args, createAnnotationDependencies({ submission })),
     };
-    io.stdin.write(
-      JSON.stringify({
-        session_id: 'sess_123',
-        transcript_path: '/tmp/transcript.json',
-        cwd: '/work',
-        permission_mode: 'plan',
-        hook_event_name: 'PermissionRequest',
-        tool_name: 'ExitPlanMode',
-        tool_input: { plan: '# Plan\n\nStep 1.\n' },
-      }),
-    );
+    io.stdin.write(JSON.stringify(claudeHookPayload.build()));
     io.stdin.end();
 
     await runHookClaude(context, deps);
@@ -99,16 +69,7 @@ describe('hookClaude handler', () => {
   it('aborts when hook_event_name is unsupported', () => {
     const { context, io, logs } = createStubContext();
     const deps = createHookDependencies();
-    io.stdin.write(
-      JSON.stringify({
-        session_id: 'sess_123',
-        transcript_path: '/tmp/transcript.json',
-        cwd: '/work',
-        hook_event_name: 'PreToolUse',
-        tool_name: 'ExitPlanMode',
-        tool_input: { plan: '# x' },
-      }),
-    );
+    io.stdin.write(JSON.stringify(claudeHookPayload.build({ hook_event_name: 'PreToolUse' })));
     io.stdin.end();
 
     expect(runHookClaude(context, deps)).rejects.toBeInstanceOf(CommanderError);
@@ -120,16 +81,7 @@ describe('hookClaude handler', () => {
   it('aborts when PermissionRequest arrives for a tool other than ExitPlanMode', () => {
     const { context, io, logs } = createStubContext();
     const deps = createHookDependencies();
-    io.stdin.write(
-      JSON.stringify({
-        session_id: 'sess_123',
-        transcript_path: '/tmp/transcript.json',
-        cwd: '/work',
-        hook_event_name: 'PermissionRequest',
-        tool_name: 'Bash',
-        tool_input: { plan: 'unused' },
-      }),
-    );
+    io.stdin.write(JSON.stringify(claudeHookPayload.build({ tool_name: 'Bash' })));
     io.stdin.end();
 
     expect(runHookClaude(context, deps)).rejects.toBeInstanceOf(CommanderError);

packages/cli/src/testFactories.ts

@@ -1,12 +1,24 @@
 import type { HarnessDescriptor } from '@contextbridge/harness';
 import { Factory } from 'fishery';
 import type { RunAnnotationArgs } from '#src/annotation/runAnnotation.ts';
+import type { ClaudeHookPayload } from '#src/commands/claudeHookSchema.ts';
 import type {
   CodexStopHookPayload,
   CodexTranscriptHookPromptLine,
   CodexTranscriptPlanLine,
 } from '#src/commands/codexHookSchema.ts';
 import type { Environment } from '#src/environment.ts';
+import type { ClaudeExitPlanModeInput } from '#src/formatters/plan/claudeHookResponse.ts';
+
+export const claudeHookPayload = Factory.define<ClaudeHookPayload & { tool_input: ClaudeExitPlanModeInput }>(() => ({
+  session_id: 'sess_123',
+  transcript_path: '/tmp/transcript.json',
+  cwd: '/work',
+  permission_mode: 'plan',
+  hook_event_name: 'PermissionRequest',
+  tool_name: 'ExitPlanMode',
+  tool_input: { plan: '# Plan\n\nStep 1.\n', planFilePath: '/home/user/.claude/plans/sample.md' },
+}));
 
 export const codexStopHookPayload = Factory.define<CodexStopHookPayload>(() => ({
   session_id: 'sess_123',