Skip to content

fix: don't crash config loading for one block failure#10140

Merged
RomneyDa merged 1 commit intomainfrom
dallin/single-block-yaml-failure
Feb 3, 2026
Merged

fix: don't crash config loading for one block failure#10140
RomneyDa merged 1 commit intomainfrom
dallin/single-block-yaml-failure

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Feb 3, 2026

Description

See #10127 (review)


Continue Tasks: ▶️ 2 queued — View all


Summary by cubic

Prevents YAML config loading from crashing when a single block fails. Null or missing blocks are filtered out, validation runs on the remaining config, and loading continues.

  • Bug Fixes

    • Filter out null entries in data, context, docs, mcpServers, models, prompts, and rules before validation.
    • Remove fatal error on missing blocks; report errors without aborting the load.
  • Refactors

    • Added a helper to normalize configs and updated configYamlToContinueConfig to take unrolledAssistant; adjusted call site.

Written for commit 5a5f5f8. Summary will update on new commits.

@RomneyDa RomneyDa requested a review from a team as a code owner February 3, 2026 08:16
@RomneyDa RomneyDa requested review from sestinj and removed request for a team February 3, 2026 08:16
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 3, 2026
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

✅ Review Complete

Code Review Summary

⚠️ Continue API authentication failed. Please check your CONTINUE_API_KEY.


Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 3, 2026
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Feb 3, 2026
@RomneyDa RomneyDa merged commit 82b606c into main Feb 3, 2026
71 of 79 checks passed
@RomneyDa RomneyDa deleted the dallin/single-block-yaml-failure branch February 3, 2026 21:29
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Feb 3, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants