Fix false-positive system tool parsing for quoted TOOL_NAME examples#11094
Open
siewcapital wants to merge 1 commit intocontinuedev:mainfrom
Open
Fix false-positive system tool parsing for quoted TOOL_NAME examples#11094siewcapital wants to merge 1 commit intocontinuedev:mainfrom
siewcapital wants to merge 1 commit intocontinuedev:mainfrom
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
I have read the CLA Document and I hereby sign the CLA |
1 similar comment
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TOOL_NAME:parsing once the assistant has already emitted non-whitespace conversational textdetectToolCallStartinstead of relying on tuple orderingWhy
When a model explains tool syntax (for example,
TOOL_NAME: read_filein a normal paragraph), the parser could misclassify that quoted text as a real tool invocation. This patch narrows the fallback path to reduce those false positives while preserving standard fenced tool-call behavior.Testing
core/tools/systemMessageTools/toolCodeblocks/interceptSystemToolCalls.vitest.tsvitestis not installed (ERR_MODULE_NOT_FOUND)Closes #11070
Continue Tasks: 🔄 7 running — View all
Summary by cubic
Prevents false-positive tool calls when the assistant shows quoted TOOL_NAME examples in normal text by limiting fallback parsing to the very start of a response. Canonical ```tool code blocks still parse normally.
Written for commit 059a085. Summary will update on new commits.