fix(openai): fix Responses API 400 errors for reasoning, tool calls, and ID handling#11785
Merged
fix(openai): fix Responses API 400 errors for reasoning, tool calls, and ID handling#11785
Conversation
dosubot
bot
added
the
size:L
Contributor
Documentation ReviewNo documentation updates are needed for this PR. Rationale: This PR contains internal bug fixes in
Users will automatically benefit from these fixes when using OpenAI models with tool calling and reasoning capabilities—no documentation changes required. |
RomneyDa
force-pushed
the
dallin/openai-issues
branch
from
43f9931 to
690d98f
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
RomneyDa
force-pushed
the
dallin/openai-issues
branch
from
690d98f to
588d81a
Compare
dosubot
bot
added
size:XL
|
Outstanding contribution on this PR. The level of detail, clarity in implementation, and overall impact make this truly exceptional work. Kudos to @xxsLuna in #11722, @Quazistax in #8935, and @pallaprolus in #9362 for driving this forward—this is a great example of high-quality engineering and meaningful contribution to the project. |
RomneyDa
force-pushed
the
dallin/openai-issues
branch
from
588d81a to
1bb3c22
Compare
This was referenced Mar 24, 2026
RomneyDa
force-pushed
the
dallin/openai-issues
branch
6 times, most recently
from
621ad1f to
ecd69b0
Compare
…and ID handling Three categories of OpenAI Responses API 400 errors are addressed: 1. "No tool call found for function call output with call_id" — function_call items are now always emitted when tool calls exist (even without fc_ IDs), and orphaned function_call_output items are removed in post-processing. 2. "Item provided without its required 'reasoning' item" — reasoning items without encrypted_content (e.g. from saved sessions) are removed, and the id is stripped from subsequent function_call items so the API doesn't reject them for referencing a missing reasoning item. Trailing reasoning items not followed by a valid successor are also removed. 3. "Expected an ID that begins with 'fc'" — responsesOutputItemIds (which accumulates both msg_ and fc_ IDs during streaming) is now filtered to only fc_-prefixed IDs for function_call items, preventing msg_ IDs from being used where fc_ IDs are required. Co-authored-by: Luna <20552038+xxsLuna@users.noreply.github.com> Co-authored-by: Robert Benko <10097827+Quazistax@users.noreply.github.com> Co-authored-by: pallaprolus <162944051+pallaprolus@users.noreply.github.com>
RomneyDa
force-pushed
the
dallin/openai-issues
branch
from
ecd69b0 to
d71d270
Compare
This was referenced Mar 25, 2026
Closed
This was referenced Mar 25, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 25, 2026
… converter The tool-call event was re-emitting the full arguments that were already streamed via tool-input-start/delta, causing JSON.parse failures in consumers. Now tool-call only emits extra_content when a Gemini thoughtSignature is present, and returns null otherwise.
RomneyDa
commented
Mar 25, 2026
Collaborator
Author
There was a problem hiding this comment.
these 2 files were changed because recent community PR CICD didn't run tests on openai adapters and some failures got through
Patrick-Erichsen
approved these changes
Mar 25, 2026
Patrick-Erichsen
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three categories of OpenAI Responses API 400 errors (~100+ open issues) in
toResponsesInput(). This is a consolidated implementation of the work done by @xxsLuna in #11722, @Quazistax in #8935, and @pallaprolus in #9362 — credit to them for diagnosing the root causes and proposing the core fixes.What's fixed
function_callitems when tool calls exist, and strip orphanedfunction_call_outputitems in post-processing.encrypted_content(stale sessions), stripidfrom their subsequentfunction_callitems, and remove trailing reasoning without a valid successor.responsesOutputItemIdsto onlyfc_-prefixed IDs, preventingmsg_IDs from leaking intofunction_callitems.Test plan