fix: resolve critical and high security vulnerabilities#11848
Conversation
Bump vulnerable dependencies and remove unused `request` package to address ~351 of ~394 npm audit vulnerabilities reported by GitHub.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Documentation ReviewNo documentation updates needed for this PR. Reason: This PR focuses exclusively on security vulnerability fixes through dependency upgrades, package overrides, and removal of deprecated packages. These are internal infrastructure changes that:
Security patching of dependencies is an internal maintenance concern that doesn't impact the user-facing documentation. |
There was a problem hiding this comment.
1 issue found across 24 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/package.json">
<violation number="1" location="docs/package.json:30">
P1: This override forces Express 4's router dependency to an incompatible major version. `path-to-regexp@8` changed the `pathToRegexp()` return shape, so Mintlify's Express-based routes can fail at startup or when matching paths.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
…in docs Merge main, resolve conflicts in vscode and cli lockfiles, and remove path-to-regexp, body-parser, send, serve-static, cookie, and minimatch overrides from docs/package.json that forced incompatible major versions on Express 4's internal dependencies.
|
Addressed the review feedback (issue identified by cubic):
|
readability.textContent can be undefined in v0.6.0, add nullish coalescing to satisfy ArticleComponent.body type constraint.
sestinj
left a comment
There was a problem hiding this comment.
Nothing seems too risky. I'm pretty sure we're not shipping with esbuild anymore?
Summary
Addresses ~351 of ~394 npm audit vulnerabilities reported by GitHub (612 on default branch), focusing on critical and high severity issues.
Vulnerability reduction by package
Critical: 31 → 0 | High: 193 → 5 | Total: ~394 → ~43
Changes
Dependency bumps:
semantic-release^21 → ^24 in config-yaml, fetch, llm-info (eliminates bundled npm@9 with ~96 transitive vulns)@semantic-release/npm→ ^13.1.5 in config-yaml, fetch, llm-info, openai-adapterstar^7.5.10 → ^7.5.13 in core, binary (fixes 6 path traversal CVEs)esbuild0.17/0.19 → ^0.25.0 in core, binary, vscode (fixes dev server request leak)@mozilla/readability^0.5 → ^0.6 in core (fixes ReDoS)react-syntax-highlighter^15 → ^16 in gui (fixes prismjs DOM Clobbering)vitest^2 → ^3 +@vitest/coverage-v8+@vitest/uiin gui (fixes esbuild/vite chain)@swc/cli^0.3 → ^0.8 in gui (fixes cross-spawn ReDoS)diff^7 → ^8 in vscode (fixes jsdiff DoS)monaco-editor^0.55 → ^0.53 in vscode (fixes dompurify XSS)mintlifybumped to ^4.2.454 in docsRemoved:
requestfrom core and vscode — deprecated package with unfixable critical vulns (form-data, qs, tough-cookie). Not imported anywhere in the codebase.Overrides added:
tar,picomatch,rollup,serialize-javascript,diff,esbuild(via vite)express,body-parser,qs,cookie,send,serve-static,path-to-regexp,tar,js-yaml,lodash,zod,minimatch,axios,@orpc/openapi,kyselyqs,picomatchpicomatchRemaining (unfixable upstream)
sqlite3→node-gyp→@tootallnate/oncechain (low severity, no upstream fix)picomatchbundled inside npm within semantic-release (can't override bundled deps)pkgin binary (deprecated, moderate, no fix)file-typein@swc/clideps (moderate, upstream fix needed)vite<=5.4.19 in vscode (can't bump to v6+ due to@types/node@16.xconstraint)Test plan
npm installsucceeds in all packagesnpm testin core, gui, vscode, cli)mintlify devnpm auditshows reduced vulnerability countsSummary by cubic
Fixes critical and high security vulnerabilities across the monorepo by upgrading dependencies and adding safe overrides (Critical 31→0, High 193→5; total
394→43). Also updatescoreto handle nullable@mozilla/readabilityv0.6.0 text content.Dependencies
esbuild(^0.25.x),tar(^7.5.13),diff(^8.0.4),react-syntax-highlighter(^16.x),@swc/cli(^0.8.x),vitest(^3.x with@vitest/coverage-v8and@vitest/ui), and pinnedmonaco-editorto ^0.53.x; docsmintlifyto ^4.2.454.semantic-releaseto ^24 and@semantic-release/npmto ^13.x inpackages/config-yaml,packages/fetch,packages/llm-info, andpackages/openai-adaptersto drop the vulnerable bundled npm@9.requestfrom core and VS Code.tar,picomatch,qs,rollup,serialize-javascript,minimatch,lodash,js-yaml).body-parser,send,serve-static,cookie,path-to-regexp,minimatch); kept safe pins forexpress,qs,tar,js-yaml,lodash,zod,axios,@orpc/openapi,kysely.Migration
mintlify dev).Written for commit 2b1606e. Summary will update on new commits.