Skip to content

fix: add guard for disposed JCEF browser in sendToWebview #11897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RomneyDa merged 2 commits into from
Mar 26, 2026
+5 −1
Merged

fix: add guard for disposed JCEF browser in sendToWebview #11897

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95ec711
fix: add guard for disposed JCEF browser in sendToWebview
RomneyDa Mar 26, 2026
01d876b
fix: add log warning when sending to disposed browser
RomneyDa Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...c/main/kotlin/com/github/continuedev/continueintellijextension/browser/ContinueBrowser.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,15 @@ class ContinueBrowser(
}

fun sendToWebview(messageType: String, data: Any? = null, messageId: String = uuid()) {
if (browser.cefBrowser.isClosed) {
log.warn("Attempted to send message to disposed browser: $messageType")
return
}
val json = gsonService.gson.toJson(BrowserMessage(messageType, messageId, data))
val jsCode = """window.postMessage($json, "*");"""
try {
browser.cefBrowser.executeJavaScript(jsCode, getGuiUrl(), 0)
} catch (error: IllegalStateException) {
} catch (error: Exception) {
log.warn(error)
}
}
Expand Down
Loading