fix(intellij): enforce results limit for glob search#12000
Open
xxsLuna wants to merge 3 commits intocontinuedev:mainfrom
Open
fix(intellij): enforce results limit for glob search#12000xxsLuna wants to merge 3 commits intocontinuedev:mainfrom
xxsLuna wants to merge 3 commits intocontinuedev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where the
maxResultsparameter was not correctly passed from the Core engine to the IntelliJ extension during glob searches, causing context overflow in large repositories.Key Changes
core/protocol/messenger/messageIde.tsto include themaxResultsparameter in thegetFileResultsrequest payload. Previously, this parameter was missing, causing the IDE implementation to receiveundefined.IntelliJIde.ktto handle themaxResultsparameter. It now filters out blank lines and uses.take(maxResults)to ensure the returned file list complies with the requested limit.Impact
@codebaseor broad glob patterns in large projects.Verification
micube-finalbranch).Closes #11999
Summary by cubic
Enforces the
maxResultslimit for glob searches in IntelliJ by passing and applying the value through the Core protocol. Aligns behavior with VS Code and prevents oversized context when using@codebaseor broad patterns in large repos.maxResultsingetFileResultsrequest.Written for commit 35b7913. Summary will update on new commits.