Fix terminal command substitution quote handling#12429
Open
pragnyanramtha wants to merge 1 commit into
Open
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes command-substitution scanning in
@continuedev/terminal-securityso it follows shell quoting rules more closely:$()and backticks when they are literal text inside single quotes<(...)This avoids unnecessary permission prompts for safe commands like
echo 'literal $(name)'while preserving and tightening detection for executable substitutions.AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
N/A - terminal-security unit test coverage only.
Tests
npx vitest run test/terminalCommandSecurity.test.ts -t "Subshell and Command Substitution"npm testnpm run buildgit diff --checkSummary by cubic
Fixes command-substitution detection in
@continuedev/terminal-securityto follow shell quoting rules. Reduces false permission prompts while tightening detection for nested and process substitutions.$()and backticks inside single quotes; keep detection inside double quotes.<(...)/>(...), but treat them as literal inside double quotes.scanCommandSubstitutions,findClosingBacktick, andfindClosingParenfor quote- and escape-aware parsing.Written for commit a1402d4. Summary will update on new commits. Review in cubic