fix: reconnect stale SSE MCP sessions#12437
Open
mturac wants to merge 1 commit into
Open
Conversation
4c05a94 to
e57c06f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #12431.
This makes SSE MCP tool, prompt, and resource calls recover from stale session or closed transport errors by resetting the client/transport, reconnecting, and retrying the operation once. The reconnect path creates a fresh MCP client so restarted SSE servers do not receive requests with an old session.
Checklist
Screen recording or screenshot
Not applicable; this is MCP connection recovery behavior.
Tests
npm run vitest -- context/mcp/MCPConnection.vitest.tsnpm run tsc:checkgit diff --checkSummary by cubic
Fixes SSE MCP calls that fail after stale or closed sessions by resetting the client/transport, reconnecting, and retrying once. Improves reliability when SSE servers restart or drop connections.
Client/Transport, callsconnectClient(true, ...), then retries once.getResource,getPrompt, andcallTool; updatedMCPManagerSingletonandcore/tools/callTool.tsto use these connection methods.Written for commit e57c06f. Summary will update on new commits. Review in cubic