fix(gui): contain sidebar markdown overflow#12940
Open
JSap0914 wants to merge 1 commit into
Open
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- allow the GUI main pane and chat step wrappers to shrink with min-w-0\n- hide horizontal overflow at the chat-scroll container while keeping code blocks horizontally scrollable\n- cap markdown/code blocks to their parent width instead of viewport width\n\nFixes #12910.\n\n## Verification\n- npx prettier --check gui/src/pages/gui/index.tsx gui/src/pages/gui/Chat.tsx gui/src/components/StepContainer/StepContainer.tsx gui/src/components/StyledMarkdownPreview/index.tsx\n- npm --prefix gui run lint -- src/pages/gui/index.tsx src/pages/gui/Chat.tsx src/components/StepContainer/StepContainer.tsx src/components/StyledMarkdownPreview/index.tsx\n- Chromium layout smoke: 420px sidebar with 5000-character unbroken code token kept document scrollWidth at 420px, Enter button right edge at 412px, and overflow inside the code block\n\n## Notes\n- npm --prefix gui run tsc:check was not usable in this checkout after package install because it reports existing core dependency/type errors outside these files.\n- npm --prefix gui test -- src/pages/gui/chat-tests/Chat.test.tsx was not usable because the existing test setup fails before collection with localStorage.getItem is not a function.