Skip to content

Fix ollama fim #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sestinj merged 1 commit into from
Oct 3, 2024
Merged

Fix ollama fim #2452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion core/llm/llms/Ollama.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ class Ollama extends BaseLLM {
model: "codellama-7b",
};

private fimSupported: boolean = false;

constructor(options: LLMOptions) {
super(options);

Expand Down Expand Up @@ -70,6 +72,13 @@ class Ollama extends BaseLLM {
}
}
}

/**
* There is no API to get the model's FIM capabilities, so we have to
* make an educated guess. If a ".Suffix" variable appears in the template
* it's a good indication the model supports FIM.
*/
this.fimSupported = !!body?.template?.includes(".Suffix");
})
.catch((e) => {
// console.warn("Error calling the Ollama /api/show endpoint: ", e);
Expand Down Expand Up @@ -251,7 +260,7 @@ class Ollama extends BaseLLM {
}

supportsFim(): boolean {
return true;
return this.fimSupported;
}

protected async *_streamFim(
Expand Down