first pass at terminal tool output ui #4565
Conversation
✅ Deploy Preview for continuedev canceled.
|
|
Resolves #4482 |
There was a problem hiding this comment.
@sestinj I ran some testing and noted a few issues with commands that might stream both stdout and stderr. Also noted some formatting issues with ANSI terminal output. By aggregating the output from stdout and stderr into a single variable, the partial dynamically updates with stdout, then stderr is added.
The way I tested this was to ask continue to write cucumber tests for test.js in the same project. Then once cucumber was added to the package.json and a "npm test" command was added I think ask: Run "npm test" to validate.
Hope this helps. This is a nice change, and really improves the terminal tool.
|
this is a huge help @chezsmithy thank you |
|
@sestinj and @RomneyDa noting this PR + my suggested changes fixes further issues my change didn't solve for when there is staggered or delayed output from the terminal command. I'd recommend accelerating this PR to fix more issues with the terminal based tool. I'll continue to run tests using this branch locally to look for additional issues. |
|
@sestinj hoping to bump this up the priority list to fix further issues with terminal commands like running jest tests fully. I believe this is a critical fix for agent mode. |
|
@chezsmithy appreciate all the input! |
|
@RomneyDa one other use case that this design doesn't solve for well is when a terminal command runs that doesn't exit. It might be good to somehow allow the user to proceed manually in this situation while the tool spins in the background. Tho not sure how you might quit it. Maybe you add a button to allow the user to continue without waiting for the terminal command to end,and then track what terminal commands are running and tack those to the context passed to the LLM. I wonder if it would then run commands to stop and restart long running processes like servers using tools? |
|
@sestinj I think this can be closed. |
No description provided.