Skip to content

Conversation

@sestinj
Copy link
Contributor

@sestinj sestinj commented Apr 14, 2025

Built on top of 5104

@sestinj sestinj requested a review from a team as a code owner April 14, 2025 18:02
@sestinj sestinj requested review from RomneyDa and removed request for a team April 14, 2025 18:02
@netlify
Copy link

netlify bot commented Apr 14, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 833cbb8
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/68111a2ab44ba50008840785

@RomneyDa RomneyDa requested review from a team, Patrick-Erichsen and tomasz-stefaniak and removed request for a team, RomneyDa and tomasz-stefaniak May 3, 2025 05:26
@RomneyDa
Copy link
Collaborator

@sestinj could update description/title/etc, looks like this PR adds ability to turn rules on/off for chat/agent?
@tomasz-stefaniak might overlap with your current work
I'm wondering how this would work for Edit mode rules, seems like since GUI only it wouldn't, which could be confusing

@sestinj sestinj changed the title fix package.json Toggle on/off rules from the notch May 19, 2025
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 19, 2025
@RomneyDa
Copy link
Collaborator

@sestinj looks like non-flaky failing tests and merge conflicts

@sestinj sestinj marked this pull request as draft June 2, 2025 20:06
@recurseml
Copy link

recurseml bot commented Jun 13, 2025

⚠️ Only 5 files will be analyzed due to processing limits.

let startIndex = 0;
while ((startIndex = nodeTextValue.indexOf(query, startIndex)) !== -1) {
while (
(startIndex = nodeTextValue?.indexOf(query, startIndex) ?? -1) !== -1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar null reference safety issue in the search loop. The original code assumed nodeTextValue would never be null when calling indexOf, which could throw a TypeError. The fix adds both optional chaining (?.) and nullish coalescing (??) to safely handle null/undefined cases by defaulting to -1, which properly terminates the loop.

📚 Relevant Docs


React with 👍 to tell me that this comment was useful, or 👎 if not (and I'll stop posting more comments like this in the future)

@recurseml
Copy link

recurseml bot commented Jun 13, 2025

😱 Found 1 issue. Time to roll up your sleeves! 😱

@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Jun 23, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2025
@sestinj sestinj deleted the nate/toggle-rules branch October 17, 2025 22:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants