Nate/config-yaml-no-node-packages #5853
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic. |
✅ Deploy Preview for continuedev canceled.
|
|
|
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
| @@ -0,0 +1,9 @@ | |||
| export default { | |||
There was a problem hiding this comment.
The configuration file uses ES Module syntax (export default) which is incompatible with semantic-release. The tool expects CommonJS module.exports format. This will cause the configuration to fail to load. Change to module.exports = { to fix the issue.
React with 👍 to tell me that this comment was useful, or 👎 if not (and I'll stop posting more comments like this in the future)
|
😱 Found 1 issue. Time to roll up your sleeves! 😱 |
Contributor
Author
|
patrick found a better way to solve this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We import the config-yaml package in the browser, so it's important to get rid of any nodejs-dependent libraries. I split anything requiring that into a new package (which should be used basically only in our extension right now).
TODO: upgrade and use this new package within the extension
Checklist
Tests
The tests were moved over to the new package. The extension itself will definitely need to be tested