Skip to content

Conversation

@drocko
Copy link

@drocko drocko commented Jun 4, 2025

Description

Appended Composition Order Details into Official Documentation
Linked to Issue #5112

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screenshots

No additional screenshots at the moment

Tests

No additional tests at the moment

@drocko drocko requested a review from a team as a code owner June 4, 2025 06:24
@drocko drocko requested review from Patrick-Erichsen and removed request for a team June 4, 2025 06:24
@cubic-dev-ai
Copy link
Contributor

cubic-dev-ai bot commented Jun 4, 2025

Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic.

@netlify
Copy link

netlify bot commented Jun 4, 2025

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit 3a0dc77
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/683fe69bbcc48300080a9b22
😎 Deploy Preview https://deploy-preview-5977--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 4, 2025
@drocko
Copy link
Author

drocko commented Jun 4, 2025

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Patrick-Erichsen
Copy link
Collaborator

Hi @drocko , apologies for the delay here, I thought I had already reviewed this.

I'm a bit confused by what "Composition Order Flow" is supposed to mean though, even after reading the issue and viewing that image.

Is the goal here to try to clarify how the context window is filled?

@drocko
Copy link
Author

drocko commented Jun 19, 2025

Hi @Patrick-Erichsen, no worries at all about the delay, and sorry if my diagram caused any confusion!

Yes, my goal was to clarify how the context window was filled aka the "Composition Order" defined by lisyoen in the original issue. Thought it would be a good first issue for me to try and tackle!

And about that diagram - I’m not sure if it’s a bug but I noticed the newest message sometimes doesn’t show up in the console logs, which made it a bit confusing to determine the actual composition order. My earlier notes and diagram were an attempt to explain that behavior, but they may have ended up making things more confusing instead.

@Patrick-Erichsen
Copy link
Collaborator

Patrick-Erichsen commented Jun 23, 2025

Got it - I appreciate the contribution but I don't think we really have anywhere good to put this in the docs right now. It isn't specifically related to the prompts.md file you added it to since that is specifically about prompt files, this "composition flow" is moreso about how we construct user messages, which is a bit too in the weed for the docs.

Closing the issue out with that in mind, but if you're looking for a good first issue I think this might be a good one: #6222

@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Jun 23, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2025
@Patrick-Erichsen
Copy link
Collaborator

Eventually I could see this going into some sort of "Context management" doc however so I'll keep it in mind 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants