-
Notifications
You must be signed in to change notification settings - Fork 3.8k
chore: add support for gpt 5.1 #8832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments, also can we
- add to the add models form in GUI
- add it to recommended agent models i.e. make sure it gets multi edit tool
- add comments about how the model was tested e.g. does it do well in agent mode? both CLI and extensions?
- make sure it's added to auto tool support
- update the docs
already present (as prefix starts with gpt-5)
tested and it works fine on cn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 7 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="docs/customize/deep-dives/model-capabilities.mdx">
<violation number="1" location="docs/customize/deep-dives/model-capabilities.mdx:175">
Update the GPT-5 context window to match the 128k limit defined in the model metadata so the capability table stays accurate.</violation>
</file>
<file name="packages/llm-info/src/providers/openai.ts">
<violation number="1" location="packages/llm-info/src/providers/openai.ts:100">
Escape the dot in the GPT‑5.1 regex so only the literal model name matches.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 8 files
| [/deepseek/, /r1|reasoner/], | ||
| [/gemini/, /2\.5/, /pro/], | ||
| [/gpt-5/], | ||
| [/gpt/, /-5|5\.1/], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may match funky dates but should be fine since 2-digit month/day won't start w 5
…instinct/gpt-5.1-support
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.36.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Support for the new gpt 5.1
resolves CON-4932
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Add support for gpt-5.1 with correct model metadata. Enables chat with a 400k context window and 128k max completion; adds it to recommended models, agent model detection, and the Add Model form; updates docs; addresses Linear CON-4932.
Written for commit dacfee0. Summary will update automatically on new commits.