Skip to content

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Nov 21, 2025

Description

Support for the new gpt 5.1

resolves CON-4932

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Add support for gpt-5.1 with correct model metadata. Enables chat with a 400k context window and 128k max completion; adds it to recommended models, agent model detection, and the Add Model form; updates docs; addresses Linear CON-4932.

  • New Features
    • Registered gpt-5.1 in the provider registry (display name, 400k context, 128k max completion).
    • Added gpt-5.1 to CometAPI recommended chat models, agent model detection, and OpenAI options in the Add Model UI.

Written for commit dacfee0. Summary will update automatically on new commits.

@uinstinct uinstinct requested a review from a team as a code owner November 21, 2025 15:20
@uinstinct uinstinct requested review from tingwai and removed request for a team November 21, 2025 15:20
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 21, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, also can we

  • add to the add models form in GUI
  • add it to recommended agent models i.e. make sure it gets multi edit tool
  • add comments about how the model was tested e.g. does it do well in agent mode? both CLI and extensions?
  • make sure it's added to auto tool support
  • update the docs

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Nov 21, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 24, 2025
@uinstinct
Copy link
Contributor Author

make sure it's added to auto tool support

already present (as prefix starts with gpt-5)

add comments about how the model was tested e.g. does it do well in agent mode? both CLI and extensions?

tested and it works fine on cn

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 7 files

Prompt for AI agents (all 2 issues)

Understand the root cause of the following 2 issues and fix them.


<file name="docs/customize/deep-dives/model-capabilities.mdx">

<violation number="1" location="docs/customize/deep-dives/model-capabilities.mdx:175">
Update the GPT-5 context window to match the 128k limit defined in the model metadata so the capability table stays accurate.</violation>
</file>

<file name="packages/llm-info/src/providers/openai.ts">

<violation number="1" location="packages/llm-info/src/providers/openai.ts:100">
Escape the dot in the GPT‑5.1 regex so only the literal model name matches.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

@uinstinct uinstinct requested a review from RomneyDa November 24, 2025 13:58
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

[/deepseek/, /r1|reasoner/],
[/gemini/, /2\.5/, /pro/],
[/gpt-5/],
[/gpt/, /-5|5\.1/],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may match funky dates but should be fine since 2-digit month/day won't start w 5

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 24, 2025
@RomneyDa RomneyDa merged commit 0fd1594 into continuedev:main Nov 25, 2025
54 of 57 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Nov 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2025
@sestinj
Copy link
Contributor

sestinj commented Nov 25, 2025

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@uinstinct uinstinct deleted the gpt-5.1-support branch November 26, 2025 04:45
@sestinj
Copy link
Contributor

sestinj commented Nov 26, 2025

🎉 This PR is included in version 1.36.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants