Cleanup validator code and add validator test#1069
Merged
brecode merged 21 commits intocontiv:masterfrom Aug 29, 2018
jmedved:master
Merged
Cleanup validator code and add validator test#1069brecode merged 21 commits intocontiv:masterfrom jmedved:master
brecode merged 21 commits intocontiv:masterfrom
jmedved:master
Conversation
- Delete unused member Report from the Node structure - Add valiator L2 connectivity tests - Clean up indexing of Node structure by VPP GigE address (remove the need for a mask) - Trim huge debug logs in controller
brecode
requested changes
Aug 29, 2018
Member
brecode
left a comment
brecode
left a comment
There was a problem hiding this comment.
vpp/plugins/crd/cache/telemetrymodel/ctm.go
Line 275 in 232b0ba
json:"vpp_sw_if_idx,omitempty"
brecode
approved these changes
Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.