Skip to content

3 fixes for the ACLs.#565

Merged
tiewei merged 1 commit intocontiv:masterfrom
milanlenco:master
Feb 1, 2018
Merged

3 fixes for the ACLs.#565
tiewei merged 1 commit intocontiv:masterfrom
milanlenco:master

Conversation

@milanlenco
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 76.783% when pulling 5be8dea on milanlenco:master into 9e6fc4d on contiv:master.

@tiewei
Copy link
Contributor

tiewei commented Feb 1, 2018

Please brief why the fixes are needed, and what it's fixing.
I can tell the cache_impl.go one is because LookupPod already returned false, nil, the 2nd update is trying to do a (deep?) copy before change ? could you have more info in your commit msg ?
ref:
https://chris.beams.io/posts/git-commit/
https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53

@jmedved
Copy link
Member

jmedved commented Feb 1, 2018

This pull request fixes a problem where ACLs for an ingress policy applied to a server pod were not correctly deleted when a client pod accessing the server was terminated.

The problem was caused by not performing a deep copy of ACLs passed to the ACL renderer, causing them to be modified while they were being rendered.

Copy link
Member

@jmedved jmedved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, +2

Copy link
Contributor

@tiewei tiewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment explained the codes, I'll squash and merge to make sure the commit msg is correct

Copy link
Member

@brecode brecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants