Merged
Conversation
tiewei
reviewed
Feb 9, 2018
| * Node configuration (section `NodeConfig`; one entry for each node) | ||
| - `NodeName`: name of a Kubernetes node; | ||
| - `UseDhcpOnMainInt`: acquire IP address for the main VPP interface using DHCP | ||
| (beware: renew of IP address is not supported) |
Contributor
There was a problem hiding this comment.
is renew lease or changing ip ?
Member
There was a problem hiding this comment.
The IP address could be changed when the lease is renewed. I guess that's what Lukas is referring to. If the lease is renewed, but the IP address stays the same, we should be fine.
Collaborator
Author
There was a problem hiding this comment.
yes correct, the change of IP address is not supported. I'll re-phrase it
jmedved
reviewed
Feb 9, 2018
| } | ||
|
|
||
| for { | ||
| select { |
Member
There was a problem hiding this comment.
Should you be getting the IP address through DHCP also in the Resync case?
jmedved
approved these changes
Feb 9, 2018
tiewei
approved these changes
Feb 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to configure DHCP on the main VPP interface. Renewal of DHCP lease is not supported.