Skip to content

Persist configIndex#647

Merged
milanlenco merged 10 commits intocontiv:masterfrom
lukasmacko:master
Mar 8, 2018
Merged

Persist configIndex#647
milanlenco merged 10 commits intocontiv:masterfrom
lukasmacko:master

Conversation

@lukasmacko
Copy link
Collaborator

@lukasmacko lukasmacko commented Mar 8, 2018

  • modfied data structure that is stored in configIndex. Only names that are necessary to remove config items are persisted.
  • containerID is used as identifier in configIndex and IPAM isntead of networkNamespace because remove request sent after restart does not contain network namespace

@coveralls
Copy link

coveralls commented Mar 8, 2018

Coverage Status

Coverage increased (+0.02%) to 75.216% when pulling f111997 on lukasmacko:master into d7314aa on contiv:master.

"github.com/contiv/vpp/plugins/contiv/containeridx/model"
"github.com/ligato/cn-infra/core"
"github.com/ligato/cn-infra/logging/logrus"
"github.com/onsi/gomega"
Copy link
Collaborator

@ondrej-fabry ondrej-fabry Mar 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use . "github.com/onsi/gomega for more readable code, without gomega. prefixes all over the place.

gomega.Expect(err).To(gomega.BeNil()) -> Expect(err).To(BeNil()) reads like normal sentence.

@milanlenco milanlenco merged commit c747f80 into contiv:master Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants