Replace ETCD with Bolt in ipam plugin#988
Merged
lukasmacko merged 2 commits intocontiv:masterfrom Aug 13, 2018
Merged
Conversation
deathbeam
force-pushed
the
ipam-bolt
branch
2 times, most recently
from
b623b1b to
8f5dc39
Compare
deathbeam
changed the title
Contributor
Author
🎉 |
deathbeam
force-pushed
the
ipam-bolt
branch
2 times, most recently
from
4bf5233 to
407efbf
Compare
lukasmacko
reviewed
Aug 7, 2018
plugins/contiv/plugin_impl_contiv.go
Outdated
| broker := plugin.ETCD.NewBroker(plugin.ServiceLabel.GetAgentPrefix()) | ||
| broker := plugin.Bolt.NewBroker(plugin.ServiceLabel.GetAgentPrefix()) | ||
| // init map with configured containers | ||
| plugin.configuredContainers = containeridx.NewConfigIndex(plugin.Log, "containers", broker) |
Collaborator
There was a problem hiding this comment.
Let's keep containeridx in etcd
lukasmacko
reviewed
Aug 7, 2018
k8s/contiv-vpp.yaml
Outdated
| - name: BOLT_CONFIG | ||
| value: "/etc/agent/bolt.conf" | ||
| - name: DEBUG_BOLT_CLIENT | ||
| value: "true" |
Collaborator
There was a problem hiding this comment.
Do not enable debug by default
Collaborator
|
Bump version of cn-infra in vpp-agent branch https://github.com/ligato/vpp-agent/tree/contiv-1807 in order to include bolt lib and use the latest commit from the branch in your PR commit Gopkg files as well |
deathbeam
force-pushed
the
ipam-bolt
branch
2 times, most recently
from
ea5cc03 to
0560a86
Compare
Contributor
Author
|
Updated |
- Instead of using ETCD as k/v store in ipam plugin, use newly introduced Bolt. - Bump cn-infra and vpp-agent Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
lukasmacko
approved these changes
Aug 8, 2018
lukasmacko
approved these changes
Aug 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using ETCD as k/v store in ipam plugin, use newly introduced
Bolt.
Signed-off-by: Tomas Slusny slusnucky@gmail.com