Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Fix: Unknown users comment displays [object Object] & MD Formatting #30

Merged
ibakshay merged 4 commits into from
Aug 5, 2020
Merged

Fix: Unknown users comment displays [object Object] & MD Formatting #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5341f7
fix markdown formatting
mmv08 Aug 4, 2020
1b820d1
build lib
mmv08 Aug 4, 2020
adee822
Fix comment formatting for unknown user part
mmv08 Aug 4, 2020
ffcdf68
Merge branch 'master' of github.com:cla-assistant/github-action into …
mmv08 Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/main.js
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions src/pullRequestComment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,8 @@ function commentContent(signed: boolean, committerMap: CommitterMap): string {
}
if (committerMap && committerMap.unknown && committerMap.unknown.length > 0) {
let seem = committerMap.unknown.length > 1 ? "seem" : "seems"
text += `<hr/>**${committerMap.unknown.join(
", "
)}** ${seem} not to be a GitHub user.`
let committerNames = committerMap.unknown.map(committer => committer.name)
text += `**${committerNames.join(", ")}** ${seem} not to be a GitHub user.`
text += ' You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).<br/>'
}
text += '<sub>You can retrigger the CLA Action by commenting **recheckcla** in this Pull Request</sub>'
Expand Down