Skip to content

Remove phpdbg from coverage target#55

Merged
f3l1x merged 1 commit intocontributte:masterfrom
ohmyfelix:chore/php-coverage-target
Mar 16, 2026
Merged

Remove phpdbg from coverage target#55
f3l1x merged 1 commit intocontributte:masterfrom
ohmyfelix:chore/php-coverage-target

Conversation

@ohmyfelix
Copy link
Copy Markdown
Contributor

Summary

Switch the coverage Makefile target from phpdbg to php so this repository follows the org-wide coverage runner migration.

Motivation

This repository is part of contributte/contributte#73, which removes phpdbg from coverage targets across Contributte packages.

Changes

  • replace -p phpdbg with -p php in both coverage target variants in Makefile
  • keep the existing coverage output targets for CI (coverage.xml) and local runs (coverage.html)

Testing

  • Tests pass locally (make tests)
  • Coverage target passes locally (make coverage)
  • CI passes

make coverage currently fails in this environment because PHP CLI has no Xdebug/PCOV extension and coverage is no longer running under PHPDBG.

Use the regular PHP binary in the coverage Makefile target to align with the org-wide phpdbg removal tracked in contributte/contributte#73.
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.83%. Comparing base (09e14dc) to head (ff280bd).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   43.44%   38.83%   -4.62%     
==========================================
  Files          24       24              
  Lines         557      515      -42     
==========================================
- Hits          242      200      -42     
  Misses        315      315              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@f3l1x f3l1x marked this pull request as ready for review March 16, 2026 19:13
@f3l1x f3l1x merged commit c958a4a into contributte:master Mar 16, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants