Migrate Utils module to CTBase#321
Merged
Merged
Conversation
- Delete src/Utils/ directory and all utility files - Delete test/suite/utils/ test files - Update dev/philosophy/modules.md and dev/planning.md - Update src/OCP/OCP.jl imports - Update test/runtests.jl to remove Utils test references - Update test files to use CTBase imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR completes the migration of the
Utilsmodule from CTModels.jl to CTBase.jl, following the architectural decision to split utilities by responsibility intoCTBase.CoreandCTBase.Interpolation.Changes
Source Code
src/Utils/directory and all utility filesUtils.jl,function_utils.jl,interpolation.jl,macros.jl,matrix_utils.jlCTModels.Utilsto:CTBase.Coreformatrix2vec,to_out_of_place,@ensureCTBase.Interpolationforctinterpolate,ctinterpolate_constantsrc/CTModels.jl- removed Utils module loadingsrc/OCP/OCP.jlandsrc/Init/Init.jl- added CTBase importsTests
test/suite/utils/directory and test filestest/README.md- removed Utils directory referencetest/suite/ocp/test_defaults.jl- useCTBase.Core.__matrix_dimension_storagetest/runtests.jl- removed Utils test referencesDocumentation
docs/api_reference.jl- removed Utils sectiondocs/src/index.md- removed Utils from submodule tableAGENTS.md- removed Utils from architectureBREAKING.md- added migration notes and updated examplesCHANGELOG.md- updated historical references to use CTBaseDependencies
Project.toml- CTBase compatibility bumped to "0.19"Developer Documentation
dev/philosophy/modules.mdanddev/planning.md- removed Utils referencesCTBase Architecture
The utilities are now organized in CTBase as:
CTBase.Core:matrix2vec(public),to_out_of_place(private),@ensure(private)CTBase.Interpolation:ctinterpolate,ctinterpolate_constantTesting
All tests pass (3521/3521):
Breaking Changes
Users importing from
CTModels.Utilsmust update their imports:CTModels.Utils.matrix2vec→CTBase.Core.matrix2vecCTModels.Utils.ctinterpolate→CTBase.Interpolation.ctinterpolateCTModels.Utils.ctinterpolate_constant→CTBase.Interpolation.ctinterpolate_constantRelated