refactor: move shared accessor ownership to Components#335
Merged
Conversation
Add accessors_api.jl with bare declarations for state, control, variable, objective, costate, times, time_grid. Components now owns and exports these generics; Models/Solutions/Init attach their own methods. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…mponents Prefix the 5 model-side method definitions with Components. (function state -> function Components.state, etc.). Remove state/control/variable/times/objective from Models exports — they are now owned and exported by Components. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…hared) to Components Requalify Models.state/control/variable/objective/times(sol) and the bare costate/time_grid declarations to Components.*. Remove costate and time_grid from Solutions exports — owned by Components. Sub-accessors (*_dimension, *_name, *_components) remain in Models. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Method definitions in Init/state,control,variable.jl and call sites in Init/validation.jl updated from Models.* to Components.*. Display/solution.jl updated for objective and variable calls. Sub-accessors (*_dimension etc.) left unchanged. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
test_export_import.jl and test_multi_grids.jl updated: Solutions.costate -> Components.costate, Solutions.time_grid -> Components.time_grid, Models.state/ control/variable/objective -> Components.*. Import of Components added to test_multi_grids.jl. Sub-accessors (state_dimension etc.) restored to Models. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
state,control,variable,objective,costate,times,time_grid) dans un nouveau fichiersrc/Components/accessors_api.jl—Componentsen est maintenant le propriétaire et l'exporteur unique.Models,Solutions,InitetDisplay:function Models.state(→function Components.state(, etc.ModelsetSolutions(évite toute ambiguïté à l'import).Solutions.costate/Solutions.time_grid.CTModels.state,CTModels.costate, etc. restent valides viausing .ComponentsdansCTModels.jl.Contexte
Suite du plan
model_solution_separation_plan.md(éclatementOCP→ sous-modules). La décision « les génériques partagées sont possédées parComponents» était actée mais n'avait été appliquée qu'au bas niveau (name/dimension/value). Ce PR l'étend aux accesseurs de haut niveau, éliminant les préfixes trompeursModels.objective(sol)ouSolutions.costate(sol)côté appelant.Suivi hors-périmètre
CTModels.state/CTModels.costate/CTModels.objective— à séquencer après merge.times/time_griden un seul nom — décision séparée.Test plan
Pkg.test()→ 3817/3817 passedModels.(state|control|variable|objective|times)niSolutions.(costate|time_grid)danssrc/(hors docstrings)🤖 Generated with Claude Code