feat: migrate display to CTBase palette + move show methods to Init/Solutions#358
Merged
Conversation
…olutions - Add Base.show for InitialGuess and PreInitialGuess in Init/show.jl using CTBase.Core.get_format_codes palette - Move Base.show for Solution from Display/solution.jl to Solutions/show.jl with fmt.success/fmt.error for solver status - Migrate definition.jl and mathematical.jl from _print_ansi_styled to CTBase palette (fmt.emphasis, fmt.keyword) - Remove _ansi_color, _ansi_reset, _print_ansi_styled from ansi.jl (only __print remains) - Add import CTBase.Core to Display module - Update docs/api_reference.jl: add Init/show.jl and Solutions/show.jl, remove Display/solution.jl - Add test suites: test_initial_guess_show.jl (23 tests) and test_solution_show.jl (15 tests) - Update module docstrings in Solutions.jl and Display.jl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the display system in CTModels.jl to use the CTBase semantic palette (CTBase.Core.get_format_codes) and moves simple Base.show methods closer to their owning modules.
Changes
Phase A — InitialGuess display in Init module
Phase B — Solution display moved to Solutions module
Phase C — Migrate definition.jl and mathematical.jl to palette + cleanup
Architecture
The Display module now focuses exclusively on Model/PreModel rendering (which depends on MLStyle, MacroTools, and RecipesBase). Simple Base.show methods that only need CTBase.Core live in their respective modules (Init, Solutions).
Test results
All 3920 tests pass (including 38 new display tests).