fix(types): add missing summary breaking change type#53
Open
goestav wants to merge 1 commit intoconventional-commits:mainfrom
Open
fix(types): add missing summary breaking change type#53goestav wants to merge 1 commit intoconventional-commits:mainfrom
goestav wants to merge 1 commit intoconventional-commits:mainfrom
Conversation
This commit solves two issues: it adds the missing breaking change type for the summary child nodes and it improves the breaking change type by splitting it up into separate types. One for the summary with the exclamation mark, and another for the breaking change footer text. This implementation should be closer to what is described in the specification[1], item 1. [1]: https://www.conventionalcommits.org/en/v1.0.0/#specification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit solves two issues: it adds the missing breaking change type for the summary child nodes and it improves the breaking change type by splitting it up into separate types. One for the summary with the exclamation mark, and another for the breaking change footer text. This implementation should be closer to what is described in the specification1, item 1.
Closes #52
Footnotes
https://www.conventionalcommits.org/en/v1.0.0/#specification ↩