feat: add hotkey to toggle top row visibility#186
Merged
conventoangelo merged 2 commits intomainfrom Mar 28, 2026
Merged
Conversation
📝 WalkthroughWalkthroughAdds a “toggle top row” feature: new AppState hotkey fields and persistence; hotkey registration and handler wiring; new Changes
Sequence DiagramsequenceDiagram
actor User
participant HotKeyService
participant AppWidget
participant AppStateNotifier
participant WindowController
participant PreferencesScreen
User->>HotKeyService: Press Toggle Top Row hotkey
HotKeyService->>AppWidget: onToggleTopRowTriggered()
AppWidget->>AppStateNotifier: notifier.updateShowTopRow(newState)
AppStateNotifier-->>AppWidget: state published
AppWidget->>AppWidget: _adjustWindowSize()
AppWidget->>AppWidget: show transient overlay
AppWidget->>WindowController: call updateShowTopRowFromMainWindow(bool)
WindowController->>PreferencesScreen: deliver method call
PreferencesScreen->>PreferencesScreen: updateShowTopRow + saveKeyboardState()
AppWidget->>AppStateNotifier: _saveAllPreferences()
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds a new global hotkey to toggle the keyboard UI’s top (number) row, wiring it through persisted AppState, hotkey registration/handling, preferences UI, and cross-window synchronization between the main and preferences windows.
Changes:
- Introduces
toggleTopRowHotKey+enableToggleTopRowHotKeyinAppState(defaults, copyWith, JSON serialize/deserialize) and notifier update methods. - Registers/handles the new hotkey via
HotKeyServiceand platform method calls, and adds a Hotkeys preferences option to configure/enable it. - Implements main-window behavior to toggle the top row and notifies the preferences window; adds/updates tests for persistence/serialization flags.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
lib/providers/app_state_provider.dart |
Adds new hotkey + enabled flag to AppState, defaults, JSON, and notifier methods. |
lib/services/hotkey_service.dart |
Registers the new hotkey and invokes a new callback on trigger. |
lib/services/method_call_handler.dart |
Handles platform updates for the new hotkey and enabled flag and re-registers hotkeys. |
lib/widgets/tabs/hotkeys_tab.dart |
Adds a preferences UI option for “Toggle Top Row”; updates default Preferences hotkey. |
lib/app.dart |
Implements _toggleTopRow, wires callback into hotkey setup, and syncs state to preferences window. |
lib/screens/preferences_screen.dart |
Receives updateShowTopRowFromMainWindow to keep preferences UI state in sync. |
test/providers/app_state_provider_test.dart |
Adds assertions for the new enable flag and default hotkey presence. |
test/services/state_service_test.dart |
Verifies persistence round-trip includes the new enable flag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
lib/providers/app_state_provider.dart (2)
77-84: Minor formatting inconsistency.The
key:parameter lacks the leading space that other hotkey initializations have (compare line 79 with lines 67, 71, 75). Similarly for line 83.🔧 Suggested formatting fix
toggleTopRowHotKey = toggleTopRowHotKey ?? HotKey( - key: PhysicalKeyboardKey.keyR, + key: PhysicalKeyboardKey.keyR, modifiers: [HotKeyModifier.alt, HotKeyModifier.control]), preferencesHotKey = preferencesHotKey ?? HotKey( - key: PhysicalKeyboardKey.keyT, + key: PhysicalKeyboardKey.keyT, modifiers: [HotKeyModifier.alt, HotKeyModifier.control]),🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@lib/providers/app_state_provider.dart` around lines 77 - 84, The HotKey initializers for toggleTopRowHotKey and preferencesHotKey have inconsistent spacing before the named `key:` parameter; update the two HotKey constructions (toggleTopRowHotKey and preferencesHotKey that use PhysicalKeyboardKey.keyR and PhysicalKeyboardKey.keyT) to match the same formatting as the other HotKey instances by adding the leading space before `key:` so all HotKey(...) calls are consistently formatted.
193-202: Same formatting inconsistency as in constructor.Lines 196-197 and 201 have inconsistent indentation for the
key:parameter.🔧 Suggested formatting fix
toggleTopRowHotKey: json['toggleTopRowHotKey'] != null ? HotKey.fromJson(json['toggleTopRowHotKey']) : HotKey( - key: PhysicalKeyboardKey.keyR, + key: PhysicalKeyboardKey.keyR, modifiers: [HotKeyModifier.alt, HotKeyModifier.control]), preferencesHotKey: json['preferencesHotKey'] != null ? HotKey.fromJson(json['preferencesHotKey']) : HotKey( - key: PhysicalKeyboardKey.keyT, + key: PhysicalKeyboardKey.keyT, modifiers: [HotKeyModifier.alt, HotKeyModifier.control]),🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@lib/providers/app_state_provider.dart` around lines 193 - 202, The toggleTopRowHotKey and preferencesHotKey default HotKey constructors have inconsistent indentation for the key: parameter (lines showing PhysicalKeyboardKey.keyR and PhysicalKeyboardKey.keyT); update the formatting so the key: lines align with the modifiers: line and match the constructor indentation style used elsewhere in HotKey(...) for both toggleTopRowHotKey and preferencesHotKey to keep consistent code style (refer to symbols HotKey, toggleTopRowHotKey, preferencesHotKey, PhysicalKeyboardKey.keyR, PhysicalKeyboardKey.keyT).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@lib/providers/app_state_provider.dart`:
- Around line 77-84: The HotKey initializers for toggleTopRowHotKey and
preferencesHotKey have inconsistent spacing before the named `key:` parameter;
update the two HotKey constructions (toggleTopRowHotKey and preferencesHotKey
that use PhysicalKeyboardKey.keyR and PhysicalKeyboardKey.keyT) to match the
same formatting as the other HotKey instances by adding the leading space before
`key:` so all HotKey(...) calls are consistently formatted.
- Around line 193-202: The toggleTopRowHotKey and preferencesHotKey default
HotKey constructors have inconsistent indentation for the key: parameter (lines
showing PhysicalKeyboardKey.keyR and PhysicalKeyboardKey.keyT); update the
formatting so the key: lines align with the modifiers: line and match the
constructor indentation style used elsewhere in HotKey(...) for both
toggleTopRowHotKey and preferencesHotKey to keep consistent code style (refer to
symbols HotKey, toggleTopRowHotKey, preferencesHotKey, PhysicalKeyboardKey.keyR,
PhysicalKeyboardKey.keyT).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: be3e1524-ad7a-4e52-83a6-cc0e6165abde
📒 Files selected for processing (8)
lib/app.dartlib/providers/app_state_provider.dartlib/screens/preferences_screen.dartlib/services/hotkey_service.dartlib/services/method_call_handler.dartlib/widgets/tabs/hotkeys_tab.darttest/providers/app_state_provider_test.darttest/services/state_service_test.dart
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@lib/app.dart`:
- Around line 241-243: Toggling the top row currently calls
keyboardNotifier.updateShowTopRow(...) then _adjustWindowSize(), but
_adjustWindowSize() (via its call to _fadeIn()) forces the keyboard to become
visible; change the flow so a top-row toggle does not force a fade-in: add a
parameter to _adjustWindowSize (e.g., forceFade or preserveVisibility)
defaulting to the current behavior, update the toggle call site (where
keyboardNotifier.updateShowTopRow is used) to call _adjustWindowSize(false) (or
preserveVisibility=true), and update _adjustWindowSize to skip calling _fadeIn()
when that flag indicates preservation; ensure any calls to _adjustWindowSize
that must still show the keyboard keep the default/true behavior and update
usages accordingly (referenced symbols: keyboardNotifier.updateShowTopRow,
_adjustWindowSize, _fadeIn, _autoHideManager.showOverlay).
- Around line 251-261: The current top-row toggle flow calls
WindowController.getAll(), controller.invokeMethod(...), and
_saveAllPreferences() as fire-and-forget; make the side effects explicit by
awaiting the async operations and adding per-call error handling: await
WindowController.getAll(), iterate controllers and await each
controller.invokeMethod('updateShowTopRowFromMainWindow', newShowTopRow) inside
a try/catch to log or handle failures, and then await _saveAllPreferences()
(also wrapped in try/catch) so persistence happens deterministically after
window updates and errors aren’t dropped silently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ef83ac56-a8c8-436f-8a96-be20678a18df
📒 Files selected for processing (4)
lib/app.dartlib/providers/app_state_provider.darttest/providers/app_state_provider_test.darttest/services/state_service_test.dart
🚧 Files skipped from review as they are similar to previous changes (2)
- test/services/state_service_test.dart
- lib/providers/app_state_provider.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new global hotkey for toggling the visibility of the top row (number row) in the keyboard UI, along with full support for configuring and enabling/disabling this hotkey through the preferences and hotkey management systems. The implementation includes state management, serialization, UI integration, and test coverage for the new feature.
Hotkey System Enhancements:
toggleTopRowHotKeyand its enable/disable flag to theAppStatemodel, including initialization, serialization, deserialization, and copy methods.AppStateNotifierwith methods to update the new hotkey and its enabled state.HotKeyServiceto register and handle the new hotkey and its callback.MethodCallHandlerto support updating the new hotkey and its enabled state from platform calls.UI and Preferences Integration:
HotKeyOptionfor "Toggle Top Row" in the hotkeys preferences tab, allowing users to change or enable/disable the hotkey.Ctrl+Alt+Tand assignedCtrl+Alt+Rto the new "Toggle Top Row" action._toggleTopRowmethod in the main app state, which toggles the top row, updates preferences, and notifies the preferences window.updateShowTopRowFromMainWindowmethod in the preferences screen to synchronize state when triggered from the main window.Testing:
AppStatemodel and JSON serialization.Summary by CodeRabbit
New Features
Bug Fixes