Skip to content

fix: 🐛 extra tax were being added for tax inclusive price #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aushamim merged 1 commit into from
Apr 12, 2026
Merged

fix: 🐛 extra tax were being added for tax inclusive price #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions includes/Illuminate/AutoRenewal.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ public function __construct() {
/**
* Filter renewal product args.
*
* @param array $product_args product args.
* @param \WC_Product $product Product Object.
* @param \WC_Order_Item $order_item Order Item Object.
* @param array $product_args product args.
* @param \WC_Product $product Product Object.
* @param \WC_Order_Item_Product $order_item Order Item Object.
*
* @return array
*/
Expand Down
22 changes: 16 additions & 6 deletions includes/Illuminate/Helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,8 +651,18 @@ public static function create_renewal_order( $subscription_id ) {
}

$order_item = $old_order->get_item( $order_item_id );
$subscription_price = get_post_meta( $subscription_id, '_subscrpt_price', true );
$product_args = array(
$subscription_price = (float) get_post_meta( $subscription_id, '_subscrpt_price', true );

// Subsctract tax from subscription price if prices include tax. WC_Order will calculate tax based on this.
if ( wc_prices_include_tax() ) {
$product = ( $order_item instanceof \WC_Order_Item_Product ) ? $order_item->get_product() : null;
$tax_class = $product ? $product->get_tax_class() : '';
$tax_rates = \WC_Tax::get_rates( $tax_class );
$taxes = \WC_Tax::calc_inclusive_tax( $subscription_price, $tax_rates );
$subscription_price = $subscription_price - array_sum( $taxes );
}

$product_args = array(
'name' => $order_item->get_name(),
'subtotal' => $subscription_price,
'total' => $subscription_price,
Expand Down Expand Up @@ -1111,13 +1121,13 @@ public static function get_parent_order( int $subscription_id ) {
/**
* Create new order for renewal.
*
* @param \WC_Order $old_order Old Order Object.
* @param \WC_Order_Item $order_item Old Order Item Object.
* @param array $product_args Product args for add product.
* @param \WC_Order $old_order Old Order Object.
* @param \WC_Order_Item_Product $order_item Old Order Item Object.
* @param array $product_args Product args for add product.
*
* @return array|false
*/
public static function create_new_order_for_renewal( \WC_Order $old_order, \WC_Order_Item $order_item, array $product_args ) {
public static function create_new_order_for_renewal( \WC_Order $old_order, \WC_Order_Item_Product $order_item, array $product_args ) {
$product = $order_item->get_product();
$user_id = $old_order->get_user_id();
$new_order = wc_create_order(
Expand Down