fix(ci): bootstrap yarn via corepack to match packageManager pin#394
Merged
Conversation
Three workflows still bootstrapped yarn via `yarn set version berry` (a Yarn v1 escape hatch) before installing. Since 38cc9a9 pinned `"packageManager": "yarn@4.10.3"` in package.json, the runner's pre-installed Yarn 1.22.22 refuses to operate against the project and errors with "Corepack must currently be enabled" — failing the first push to main after the pin. Concrete fallout from PR #390's merge: - pages.yml: failed at "Installing npm packages" - release-please.yml publish jobs: failed at "Install deps" for packages/types, packages/utils, packages/js-sdk — leaving the v3.13.0 / v2.4.0 / v4.4.2 releases created on GitHub but never published to npm. - publish-package.yml: same defect, latent until next manual workflow_dispatch. Replace the v1 bootstrap with `corepack enable` + `corepack prepare yarn@4.10.3 --activate` (matching the package.json pin), then a plain `yarn` install — same pattern qa.yml already uses successfully. Also bumps pages.yml's `actions/setup-node@v1` and `actions/checkout@v2` to `@v4` (both prior versions are EOL). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
…ad-only Plain `yarn` in CI is *effectively* immutable because Yarn 4 enables `enableImmutableInstalls` when `CI=true` (which GitHub Actions auto-sets). Relying on that is brittle — `--immutable` makes the intent explicit and fails loudly with YN0028 if yarn.lock would be mutated, instead of depending on environment auto-detection. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
JosephSamirL
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yarn set version berrytrick. Since thepackageManager: yarn@4.10.3pin landed in 38cc9a9, that bootstrap now fails on push tomain— the runner's pre-installed Yarn 1.22.22 refuses to operate against a project with apackageManagerfield and demands corepack.pages.ymlfailed at "Installing npm packages" → run26406885986.release-please.ymlpublish jobs failed at "Install deps" forpackages/types,packages/utils,packages/js-sdk→ run26406886058. The release tags got created (v3.13.0 / v2.4.0 / v4.4.2 exist on GitHub), but none were published to npm.publish-package.ymlhas the same defect — latent until the next manualworkflow_dispatch.qa.yml:corepack enable+corepack prepare yarn@4.10.3 --activate(matching the explicit pin), then plainyarninstall. Theyarn set version berryline is removed from all three workflows.pages.yml'sactions/setup-node@v1andactions/checkout@v2to@v4(both prior majors are EOL).Test plan
Running QA automated checkspasses on this PR (it doesn't use any of the changed files, but should remain green).Updating Github pagesrun onmainsucceeds.gh workflow run publish-package.yml -f tag=js-sdk-types-v3.13.0gh workflow run publish-package.yml -f tag=js-sdk-utils-v2.4.0gh workflow run publish-package.yml -f tag=js-sdk-v4.4.2🤖 Generated with Claude Code