Closed
Conversation
Contributor
Author
MiguelMoll
reviewed
Jan 30, 2017
| "ManagedPolicyArns": [ | ||
| { "Ref": "KernelUserPolicy" }, | ||
| { "Ref": "KernelUserIAMPolicy" }, | ||
| { "Ref": "KernelUserGeneralPolicy" } |
Contributor
There was a problem hiding this comment.
KernelUserGeneralPolicy should be added to the DependsOn for the user resource.
Codecov Report@@ Coverage Diff @@
## master #1642 +/- ##
=======================================
Coverage 29.93% 29.93%
=======================================
Files 138 138
Lines 13347 13347
=======================================
Hits 3996 3996
Misses 8922 8922
Partials 429 429Continue to review full report at Codecov.
|
MiguelMoll
approved these changes
Jan 30, 2017
MiguelMoll
added a commit
that referenced
this pull request
Jan 30, 2017
SonOfBytes
pushed a commit
to SonOfBytes/rack
that referenced
this pull request
Mar 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this might cause another ECS Service replacement. We should test for that and take appropriate actions to mitigate update issues if so.
Break out general KernelUser policy to avoid AWS character limits.
Over time we will move more of these into "locked down" policy documents.