fix(server): recognize duration and time required as time aliases#342
Merged
Conversation
The Cooklang spec lists `time`, `duration`, and `time required` as aliases for the canonical `time` key, but the server only looked up `time`, so the other two were silently dropped from the recipe page. Closes #320
Code Review — PR #342OverviewAdds fallback lookups for Code Quality
Potential Issues
VerdictLooks good. The fix is correct, consistent with the existing code style, and closes the reported issue cleanly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
time,duration, andtime requiredas aliases for the canonicaltimemetadata key (seecooklang-rs/src/metadata.rs:87), but the server's recipe and menu pages only looked up the literaltimekey, so recipes using either alias rendered no time pill.durationandtime requiredin bothrecipe_pageand the menu handler, mirroring the existing alias pattern used forprep time/cook time.Test plan
cargo fmt,cargo clippy,cargo testcleancook serverwith three recipes (time:,duration:,time required:) — all three render the same⏱️ <value>pill, no duplication under custom metadataCloses #320