Conversation
ansible_hostname is the host's hostname, discovered by ansible facts inventory_hostname is the name used in inventory files, no need to be resolvable by dns inventory_hostname_short is the same above but truncated to the first dot, so mysite.org becomes mysite
* Delegate to playbook the delegation to localhost: instead of doing "delegate_to" in each task or block, it makes sense to just make sure to execute it everything in localhost. * Restic role needs the facts of the actual host being run, not some remote one * Also, add an assert to ensure it,
Collaborator
Author
|
@danypr92 can you have a look at this? You don't need to test it, it's already working. |
Collaborator
Author
|
addresses #20 's item "all tasks must be named" |
enricostano
approved these changes
Jun 18, 2019
danypr92
reviewed
Jun 18, 2019
| backups_role_cron_job_at: '45 3 * * *' | ||
|
|
||
| backups_role_restic_repo_name: "{{ ansible_hostname }}" | ||
| backups_role_restic_repo_name: "{{ inventory_hostname_short }}" |
Member
There was a problem hiding this comment.
I prefer to name the repo as the entire inventory_hostname and not the short one because this short can generate errors if we reuse the same prefix as in odoo.coopdevs.org and odoo.facto.coop...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polish the first iteration of the local-restore.