Merged
Conversation
* now cron-main at the template rendering stage, the cron prepare and cron upload * the combined rendered template is installed as the only backup script at the host. * update README with the variable changes * renamed backups_role_script_path to backups_role_script_dir * backups_role_script_path now means install path of backups script, instead of the parent dir. * collapsed 3-character ... into 1-char ellipsis … * removed redundant code from prepare and upload templates, as we no longer need to define title function 3 times
Collaborator
Author
|
@danypr92 it is tested and working in my environment. Can you have a look and see if there's something you disagree with? |
enricostano
approved these changes
Jun 18, 2019
raneq
commented
Jun 18, 2019
This becomes an issue when doing local_restore. However, in local_restore we were using inventory_hostname_short, which would make collide hosts like odoo.coopdevs.org and odoo.some-other.coop
Add the `backups_role_path` var to the README and explain it Co-Authored-By: raneq <46573858+raneq@users.noreply.github.com>
danypr92
approved these changes
Jun 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15