Disable auto payment #231
Disable auto payment #231
Conversation
Gemfile
Outdated
| @@ -1,5 +1,5 @@ | |||
| source 'https://rubygems.org' | |||
| ruby '2.3.0' | |||
| ruby '2.3.1' | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Algún dia lo arreglaremos verdad @enricostano 😬 😬
Gemfile.lock
Outdated
| whenever | ||
|
|
||
| RUBY VERSION | ||
| ruby 2.3.1p112 |
There was a problem hiding this comment.
There was a problem hiding this comment.
How is this ruby version thing @enricostano ? I need it to run this PR in my machine... we better fix it asap so that this branch can be merged without this change.
There was a problem hiding this comment.
Porfi quitemos los cambios relacionados a ruby de este PR. Tenemos que arreglar algo en production antes de poder tener esto listo.
Hay un PR esperando a que podamos hacer los cambios necesarios en production... De momento please.. simplemente ignorar estos cambios.
Gracias por la paciencia.
|
Ok @enricostano. Es uno de los issues que he tenido con el provisioning. |
sauloperez
force-pushed
the
disable-auto-payment
branch
from
7984e6a to
9051d6e
Compare
Gemfile.lock
Outdated
| whenever | ||
|
|
||
| RUBY VERSION | ||
| ruby 2.3.1p112 |
There was a problem hiding this comment.
How is this ruby version thing @enricostano ? I need it to run this PR in my machine... we better fix it asap so that this branch can be merged without this change.
| ) | ||
|
|
||
| if transfer.valid? | ||
| transfer.make_movements |
There was a problem hiding this comment.
note is not persisted yet. Pending. So far, there's no way not to make the movement if the record is not valid.
|
|
||
| def different_source_and_destination | ||
| return unless source == destination | ||
| errors.add(:base, :same_account) |
There was a problem hiding this comment.
this gets populated from the locales below by rails
I only tried to make a transfer and it worked. I followed EDD; going through each of the errors until it worked, because I didn't find any test for this action in the controller. Unit testing the service should be the next task.
1.4.0 is reported to have a bug: DatabaseCleaner/database_cleaner#317
This disables transfering time to yourself
This reverts commit dbde5c5.
This reverts commit 6c4202b.
It adds a validation on the Transfer model and shows a flash error message when that happens, without making the actual movement.
Due to a bug passing the string argument to #link_to, said string didn't show up in the page. The way is written now, it shows, so we need to hide it to be consistent.
|
Everything works fine 👍 Thanks @sauloperez |
enricostano
force-pushed
the
disable-auto-payment
branch
from
7b80b7b to
c6f4fc9
Compare
|
🎉 |
This addresses http://community.coopdevs.org/t/evitar-pago-de-horas-a-uno-mismo/52
It is veeeery early stage. Now what I want to do is add unit tests to this GiveTime service. Once done, I'll be able to move around with confidence and forbid the following:
As you can see below, it translated it in the three languages, and I also removed the clock icon.